From 4a327c04ff5c36dd6e6e85e1c28fc2e8e4912a2d Mon Sep 17 00:00:00 2001 From: Tournier Quentin Date: Sat, 19 Jul 2025 14:31:40 +0200 Subject: [PATCH 1/2] fix(SMS-116): remove delete otp method --- .../java/dev/resms/core/net/HttpMethod.java | 1 - src/main/java/dev/resms/services/otp/Otp.java | 23 ------------------- .../services/otp/model/DeleteOtpResponse.java | 11 --------- 3 files changed, 35 deletions(-) delete mode 100644 src/main/java/dev/resms/services/otp/model/DeleteOtpResponse.java diff --git a/src/main/java/dev/resms/core/net/HttpMethod.java b/src/main/java/dev/resms/core/net/HttpMethod.java index 7a7f9a9..fd75db3 100644 --- a/src/main/java/dev/resms/core/net/HttpMethod.java +++ b/src/main/java/dev/resms/core/net/HttpMethod.java @@ -4,5 +4,4 @@ public enum HttpMethod { GET, POST, - DELETE, } diff --git a/src/main/java/dev/resms/services/otp/Otp.java b/src/main/java/dev/resms/services/otp/Otp.java index e807087..a980faa 100644 --- a/src/main/java/dev/resms/services/otp/Otp.java +++ b/src/main/java/dev/resms/services/otp/Otp.java @@ -6,14 +6,12 @@ import dev.resms.core.service.BaseService; import dev.resms.services.otp.model.CreateOtpOptions; import dev.resms.services.otp.model.CreateOtpResponse; -import dev.resms.services.otp.model.DeleteOtpResponse; import dev.resms.services.otp.model.VerifyOtpOptions; import dev.resms.services.otp.model.VerifyOtpResponse; public class Otp extends BaseService { private static final String CREATE_OTP_PATH = "/otp"; private static final String VERIFY_OTP_PATH = "/otp/verify"; - private static final String DELETE_OTP_PATH = "/otp"; /** * Constructs an instance of the {@code Otp} class. @@ -65,25 +63,4 @@ public VerifyOtpResponse verify(VerifyOtpOptions verifyOtpOptions) throws ReSMSE return reSMSMapper.fromJson(response.getBody(), VerifyOtpResponse.class); } - - /** - * Delete an OTP based on its id - * - * @param otpId The id of the OTP to delete. - * @return The response indicating the status of the OTP deletion. - * @throws ReSMSException If an error occurs while deleting the OTP. - */ - public DeleteOtpResponse delete(String otpId) throws ReSMSException { - String payload = "{\"otpId\": \"" + otpId + "\"}"; - - AbstractHttpResponse response = - super.httpClient.perform(DELETE_OTP_PATH, apiKey, HttpMethod.DELETE, payload); - - if (!response.isSuccessful()) { - throw new ReSMSException( - "Failed to create otp: " + response.getCode() + " " + response.getBody()); - } - - return reSMSMapper.fromJson(response.getBody(), DeleteOtpResponse.class); - } } diff --git a/src/main/java/dev/resms/services/otp/model/DeleteOtpResponse.java b/src/main/java/dev/resms/services/otp/model/DeleteOtpResponse.java deleted file mode 100644 index 34ffe54..0000000 --- a/src/main/java/dev/resms/services/otp/model/DeleteOtpResponse.java +++ /dev/null @@ -1,11 +0,0 @@ -package dev.resms.services.otp.model; - -import dev.resms.core.model.Response; -import lombok.Getter; - -@Getter -public class DeleteOtpResponse extends Response { - private String otpId; - private String phoneNumber; - private String revokedAt; -} From 4d9afacd2473af7e3a9598cbf334eb6653c2b0b7 Mon Sep 17 00:00:00 2001 From: Tournier Quentin Date: Sat, 19 Jul 2025 14:32:07 +0200 Subject: [PATCH 2/2] fix(SMS-116): path send sms method --- src/main/java/dev/resms/services/sms/Sms.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/dev/resms/services/sms/Sms.java b/src/main/java/dev/resms/services/sms/Sms.java index 6c8193d..cfe3675 100644 --- a/src/main/java/dev/resms/services/sms/Sms.java +++ b/src/main/java/dev/resms/services/sms/Sms.java @@ -9,7 +9,7 @@ import dev.resms.services.sms.validator.SendSmsOptionsValidator; public class Sms extends BaseService { - private static final String SEND_SMS_PATH = "/sms/send"; + private static final String SEND_SMS_PATH = "/sms"; /** * Constructs an instance of the {@code Sms} class.