From 4326947fd8512272dfb586540126eddf12d20a96 Mon Sep 17 00:00:00 2001
From: Ryan Schmitt <rschmitt@apache.org>
Date: Tue, 30 Dec 2025 14:58:29 -0500
Subject: [PATCH] Upgrade Apache RAT

During local development, I'm regularly annoyed by spurious RAT
failures. While RAT does have some limitations -- for example, because
it never shells out to `git`, it can't ignore untracked files -- newer
versions do have improved support for `.gitignore` files, including the
global gitignore file when present at `~/.config/git/ignore` (the
default location). Additionally, the default exclusions have been
improved, so we no longer need quite as much manual configuration.

Specific changes:

1. Bumped `apache-rat-plugin` directly to 0.17. (In the version of the
   Apache parent POM we are using, there is no property we can override
   to do this.)
2. Removed exclusions that are obsolete or covered by our defaults.
3. Changed `apache-rat:check` to only run in `:httpcore5-parent`,
   instead of separately validating each subproject.
4. Changed `<exclude>` to `<inputExclude>` as the former is now
   deprecated.
---
 pom.xml | 25 ++++++++++---------------
 1 file changed, 10 insertions(+), 15 deletions(-)

diff --git a/pom.xml b/pom.xml
index 8861d723a..2bbdd033e 100644
--- a/pom.xml
+++ b/pom.xml
@@ -269,28 +269,23 @@
       <plugin>
         <groupId>org.apache.rat</groupId>
         <artifactId>apache-rat-plugin</artifactId>
+        <version>0.17</version>
         <executions>
           <execution>
             <phase>verify</phase>
+            <inherited>false</inherited>
             <goals>
               <goal>check</goal>
             </goals>
           </execution>
         </executions>
-        <configuration>
-          <excludes>
-            <exclude>**/.checkstyle</exclude>
-            <exclude>**/.pmd</exclude>
-            <exclude>**/*.iml</exclude>
-            <exclude>**/.externalToolBuilders/**</exclude>
-            <exclude>maven-eclipse.xml</exclude>
-            <exclude>src/docbkx/resources/**</exclude>
-            <exclude>src/test/resources/*.truststore</exclude>
-            <exclude>src/test/resources/*.p12</exclude>
-            <exclude>**/.dockerignore</exclude>
-            <!-- Eclipse can leave some file in 'bin' when an imported project misconfigured. -->
-            <exclude>bin/**</exclude>
-          </excludes>
+        <configuration combine.self="override">
+          <excludeSubProjects>false</excludeSubProjects>
+          <inputExcludes>
+            <inputExclude>**/*.pem</inputExclude>
+            <inputExclude>**/.pmd</inputExclude>
+            <inputExclude>**/maven-eclipse.xml</inputExclude>
+          </inputExcludes>
         </configuration>
       </plugin>
     </plugins>
@@ -396,4 +391,4 @@
     </plugins>
   </reporting>
 
-</project>
\ No newline at end of file
+</project>