From fca86ea554505ae0e7491286e5c8bb9cc1224403 Mon Sep 17 00:00:00 2001
From: Hiroshi Takemoto <hiroshi.takemoto@outlook.com>
Date: Wed, 10 May 2023 10:26:12 -0400
Subject: [PATCH] properly set PKCE values if client_secret is not present in
 configurations

---
 cli/utils/generator.py | 2 +-
 src/js/auth.js         | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/cli/utils/generator.py b/cli/utils/generator.py
index 40859fa..292f088 100644
--- a/cli/utils/generator.py
+++ b/cli/utils/generator.py
@@ -68,7 +68,7 @@ def generate_rendered_config_file(
 	    	"client_id": f"{client_id}",
 	    	"redirect_uri": f"https://{cloudfront_host}/_callback",
 	    	"grant_type": "authorization_code",
-	    	"client_secret": f"{client_secret}"
+	    	"client_secret": f"{client_secret}" if client_secret else None
 	    },
 	    "DISTRIBUTION": "amazon-oai",
 	    "AUTHN": f"{idp_name}",
diff --git a/src/js/auth.js b/src/js/auth.js
index 2755859..9275a11 100644
--- a/src/js/auth.js
+++ b/src/js/auth.js
@@ -256,7 +256,7 @@ async function setConfig() {
 	}
 
 	// set PKCE values if client_secret is not present in configurations
-	if (config.TOKEN_REQUEST.client_secret == undefined){
+	if (!config.TOKEN_REQUEST.client_secret) {
 		config.AUTH_REQUEST.code_challenge_method = "S256";
 		config.AUTH_REQUEST.code_challenge = pkceCodeChallenge;
 		config.AUTH_REQUEST.state = "state";