Skip to content

Conversation

@jacekradko
Copy link
Member

@jacekradko jacekradko commented Dec 30, 2025

Description

Hide Web3 wallet address from Organization Switcher when Personal account is selected

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Bug Fixes

    • Personal account display in the organization switcher and lists no longer shows the primary Web3 wallet as a visible identifier.
  • Tests

    • Added a test to verify user identifiers remain hidden in the personal workspace trigger.
  • Refactor

    • Internal data handling updated across organization switcher components to ensure identifiers are excluded where appropriate.

✏️ Tip: You can customize this high-level summary in your review settings.

@changeset-bot
Copy link

changeset-bot bot commented Dec 30, 2025

🦋 Changeset detected

Latest commit: e92f23e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@clerk/ui Patch
@clerk/chrome-extension Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Dec 30, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Dec 31, 2025 2:07am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 30, 2025

📝 Walkthrough

Walkthrough

The PR updates destructuring of user objects across multiple OrganizationSwitcher and OrganizationList components to explicitly extract primaryWeb3Wallet and, in some files, also primaryEmailAddress, primaryPhoneNumber, and username, altering which fields are left in userWithoutIdentifiers. A test was added to verify that user identifiers (email and username) are not shown in the personal workspace trigger. A changelog entry was added documenting the change.

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix(ui): Remove Personal Account web3 id' is partially related to the changeset. It mentions removing web3 identifiers from the personal account context, but the actual changes involve extracting and excluding primaryWeb3Wallet from various components' destructuring logic. The title is somewhat vague about the technical implementation—it doesn't clarify that the fix involves modifying destructuring patterns across multiple components and restructuring userWithoutIdentifiers.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 695a6ec and e92f23e.

📒 Files selected for processing (1)
  • .changeset/witty-walls-wave.md
✅ Files skipped from review due to trivial changes (1)
  • .changeset/witty-walls-wave.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (25)
  • GitHub Check: Integration Tests (nextjs, chrome, 16, RQ)
  • GitHub Check: Integration Tests (nextjs, chrome, 15)
  • GitHub Check: Integration Tests (quickstart, chrome, 15)
  • GitHub Check: Integration Tests (machine, chrome, RQ)
  • GitHub Check: Integration Tests (quickstart, chrome, 16)
  • GitHub Check: Integration Tests (nextjs, chrome, 16)
  • GitHub Check: Integration Tests (billing, chrome, RQ)
  • GitHub Check: Integration Tests (sessions, chrome)
  • GitHub Check: Integration Tests (react-router, chrome)
  • GitHub Check: Integration Tests (machine, chrome)
  • GitHub Check: Integration Tests (custom, chrome)
  • GitHub Check: Integration Tests (billing, chrome)
  • GitHub Check: Integration Tests (astro, chrome)
  • GitHub Check: Integration Tests (handshake, chrome)
  • GitHub Check: Integration Tests (vue, chrome)
  • GitHub Check: Integration Tests (handshake:staging, chrome)
  • GitHub Check: Integration Tests (nuxt, chrome)
  • GitHub Check: Integration Tests (sessions:staging, chrome)
  • GitHub Check: Integration Tests (tanstack-react-start, chrome)
  • GitHub Check: Integration Tests (express, chrome)
  • GitHub Check: Integration Tests (ap-flows, chrome)
  • GitHub Check: Integration Tests (generic, chrome)
  • GitHub Check: Integration Tests (localhost, chrome)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: Analyze (javascript-typescript)

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 30, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7531

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7531

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7531

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7531

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7531

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7531

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@7531

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7531

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7531

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7531

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7531

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7531

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7531

@clerk/react

npm i https://pkg.pr.new/@clerk/react@7531

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7531

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7531

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7531

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7531

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@7531

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7531

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7531

commit: e92f23e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants