🤖 fix: satisfy static-check

ThomasK33 · ThomasK33 · commit fb652b805307 · 2025-12-18T14:10:34.000+01:00
Signed-off-by: Thomas Kosiewski &lt;tk@coder.com&gt;

---
_Generated with `codex cli` • Model: `gpt-5.2` • Thinking: `xhigh`_
&lt;!-- mux-attribution: model=gpt-5.2 thinking=xhigh --&gt;

Change-Id: I1602bf485713861acc0901f8dda99ac45365be25
diff --git a/src/browser/components/Settings/sections/TasksSection.tsx b/src/browser/components/Settings/sections/TasksSection.tsx
@@ -66,9 +66,7 @@ export function TasksSection() {
 
   const setMaxParallelAgentTasks = (rawValue: string) => {
     const parsed = Number(rawValue);
-    setSettings((prev) =>
-      normalizeTaskSettings({ ...prev, maxParallelAgentTasks: parsed })
-    );
+    setSettings((prev) => normalizeTaskSettings({ ...prev, maxParallelAgentTasks: parsed }));
   };
 
   const setMaxTaskNestingDepth = (rawValue: string) => {
@@ -129,4 +127,3 @@ export function TasksSection() {
     </div>
   );
 }
-
diff --git a/src/browser/utils/ui/workspaceFiltering.test.ts b/src/browser/utils/ui/workspaceFiltering.test.ts
@@ -310,7 +310,12 @@ describe("buildSortedWorkspacesByProject", () => {
     };
 
     const result = buildSortedWorkspacesByProject(projects, metadata, recency);
-    expect(result.get("/project/a")?.map((w) => w.id)).toEqual(["root", "child1", "grand", "child2"]);
+    expect(result.get("/project/a")?.map((w) => w.id)).toEqual([
+      "root",
+      "child1",
+      "grand",
+      "child2",
+    ]);
   });
 
   it("should not duplicate workspaces that exist in both config and have creating status", () => {
diff --git a/src/browser/utils/ui/workspaceFiltering.ts b/src/browser/utils/ui/workspaceFiltering.ts
@@ -85,8 +85,7 @@ export function computeWorkspaceDepthMap(
     visiting.add(workspaceId);
     const workspace = byId.get(workspaceId);
     const parentId = workspace?.parentWorkspaceId;
-    const depth =
-      parentId && byId.has(parentId) ? Math.min(computeDepth(parentId) + 1, 32) : 0;
+    const depth = parentId && byId.has(parentId) ? Math.min(computeDepth(parentId) + 1, 32) : 0;
     visiting.delete(workspaceId);
 
     depths.set(workspaceId, depth);
diff --git a/src/common/orpc/schemas/project.ts b/src/common/orpc/schemas/project.ts
@@ -45,12 +45,10 @@ export const WorkspaceConfigSchema = z.object({
     description: "ISO 8601 timestamp for when an agent task reported completion (optional).",
   }),
   taskModelString: z.string().optional().meta({
-    description:
-      "Model string used to run this agent task (used for restart-safe resumptions).",
+    description: "Model string used to run this agent task (used for restart-safe resumptions).",
   }),
   taskThinkingLevel: ThinkingLevelSchema.optional().meta({
-    description:
-      "Thinking level used for this agent task (used for restart-safe resumptions).",
+    description: "Thinking level used for this agent task (used for restart-safe resumptions).",
   }),
   mcp: WorkspaceMCPOverridesSchema.optional().meta({
     description: "Per-workspace MCP overrides (disabled servers, tool allowlists)",
diff --git a/src/common/types/tasks.ts b/src/common/types/tasks.ts
@@ -27,8 +27,7 @@ function clampInt(value: unknown, fallback: number, min: number, max: number): n
 }
 
 export function normalizeTaskSettings(raw: unknown): TaskSettings {
-  const record =
-    raw && typeof raw === "object" ? (raw as Record<string, unknown>) : ({} as const);
+  const record = raw && typeof raw === "object" ? (raw as Record<string, unknown>) : ({} as const);
 
   const maxParallelAgentTasks = clampInt(
     record.maxParallelAgentTasks,
@@ -59,4 +58,3 @@ export function normalizeTaskSettings(raw: unknown): TaskSettings {
 
   return result;
 }
-
diff --git a/src/node/services/agentPresets.ts b/src/node/services/agentPresets.ts
@@ -80,4 +80,3 @@ export function getAgentPreset(agentType: string | undefined): AgentPreset | nul
   const normalized = (agentType ?? "").trim().toLowerCase();
   return PRESETS_BY_AGENT_TYPE[normalized] ?? null;
 }
-
diff --git a/src/node/services/taskService.test.ts b/src/node/services/taskService.test.ts
@@ -20,7 +20,7 @@ function initGitRepo(projectPath: string): void {
   execSync("git init -b main", { cwd: projectPath, stdio: "ignore" });
   execSync('git config user.email "test@example.com"', { cwd: projectPath, stdio: "ignore" });
   execSync('git config user.name "test"', { cwd: projectPath, stdio: "ignore" });
-  execSync('bash -lc \'echo \"hello\" > README.md\'', { cwd: projectPath, stdio: "ignore" });
+  execSync("bash -lc 'echo \"hello\" > README.md'", { cwd: projectPath, stdio: "ignore" });
   execSync("git add README.md", { cwd: projectPath, stdio: "ignore" });
   execSync('git commit -m "init"', { cwd: projectPath, stdio: "ignore" });
 }
@@ -45,17 +45,15 @@ describe("TaskService", () => {
     await fsPromises.rm(rootDir, { recursive: true, force: true });
   });
 
-  test(
-    "enforces maxTaskNestingDepth",
-    async () => {
+  test("enforces maxTaskNestingDepth", async () => {
     const config = new Config(rootDir);
     await fsPromises.mkdir(config.srcDir, { recursive: true });
 
     // Deterministic IDs for workspace names.
     const ids = ["aaaaaaaaaa", "bbbbbbbbbb", "cccccccccc"];
     let nextIdIndex = 0;
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
-    (config as any).generateStableId = () => ids[nextIdIndex++] ?? "dddddddddd";
+    const configWithStableId = config as unknown as { generateStableId: () => string };
+    configWithStableId.generateStableId = () => ids[nextIdIndex++] ?? "dddddddddd";
 
     const projectPath = path.join(rootDir, "repo");
     await fsPromises.mkdir(projectPath, { recursive: true });
@@ -104,30 +102,27 @@ describe("TaskService", () => {
 
     const aiService: AIService = {
       isStreaming: mock(() => false),
-      getWorkspaceMetadata: mock(async (workspaceId: string): Promise<Result<WorkspaceMetadata>> => {
-        const all = await config.getAllWorkspaceMetadata();
-        const found = all.find((m) => m.id === workspaceId);
-        return found ? Ok(found) : Err("not found");
-      }),
-      // eslint-disable-next-line @typescript-eslint/no-empty-function
-      on: mock(() => {}),
-      // eslint-disable-next-line @typescript-eslint/no-empty-function
-      off: mock(() => {}),
+      getWorkspaceMetadata: mock(
+        async (workspaceId: string): Promise<Result<WorkspaceMetadata>> => {
+          const all = await config.getAllWorkspaceMetadata();
+          const found = all.find((m) => m.id === workspaceId);
+          return found ? Ok(found) : Err("not found");
+        }
+      ),
+      on: mock(() => undefined),
+      off: mock(() => undefined),
     } as unknown as AIService;
 
     const workspaceService: WorkspaceService = {
       sendMessage: mock(() => Promise.resolve(Ok(undefined))),
       resumeStream: mock(() => Promise.resolve(Ok(undefined))),
       remove: mock(() => Promise.resolve(Ok(undefined))),
-      // eslint-disable-next-line @typescript-eslint/no-empty-function
       emit: mock(() => true),
     } as unknown as WorkspaceService;
 
     const initStateManager: InitStateManager = {
-      // eslint-disable-next-line @typescript-eslint/no-empty-function
-      startInit: mock(() => {}),
-      // eslint-disable-next-line @typescript-eslint/no-empty-function
-      appendOutput: mock(() => {}),
+      startInit: mock(() => undefined),
+      appendOutput: mock(() => undefined),
       endInit: mock(() => Promise.resolve()),
     } as unknown as InitStateManager;
 
@@ -159,20 +154,16 @@ describe("TaskService", () => {
     if (!second.success) {
       expect(second.error).toContain("maxTaskNestingDepth");
     }
-    },
-    20_000
-  );
+  }, 20_000);
 
-  test(
-    "queues tasks when maxParallelAgentTasks is reached and starts them when a slot frees",
-    async () => {
+  test("queues tasks when maxParallelAgentTasks is reached and starts them when a slot frees", async () => {
     const config = new Config(rootDir);
     await fsPromises.mkdir(config.srcDir, { recursive: true });
 
     const ids = ["aaaaaaaaaa", "bbbbbbbbbb", "cccccccccc", "dddddddddd"];
     let nextIdIndex = 0;
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
-    (config as any).generateStableId = () => ids[nextIdIndex++] ?? "eeeeeeeeee";
+    const configWithStableId = config as unknown as { generateStableId: () => string };
+    configWithStableId.generateStableId = () => ids[nextIdIndex++] ?? "eeeeeeeeee";
 
     const projectPath = path.join(rootDir, "repo");
     await fsPromises.mkdir(projectPath, { recursive: true });
@@ -234,15 +225,15 @@ describe("TaskService", () => {
 
     const aiService: AIService = {
       isStreaming: mock(() => false),
-      getWorkspaceMetadata: mock(async (workspaceId: string): Promise<Result<WorkspaceMetadata>> => {
-        const all = await config.getAllWorkspaceMetadata();
-        const found = all.find((m) => m.id === workspaceId);
-        return found ? Ok(found) : Err("not found");
-      }),
-      // eslint-disable-next-line @typescript-eslint/no-empty-function
-      on: mock(() => {}),
-      // eslint-disable-next-line @typescript-eslint/no-empty-function
-      off: mock(() => {}),
+      getWorkspaceMetadata: mock(
+        async (workspaceId: string): Promise<Result<WorkspaceMetadata>> => {
+          const all = await config.getAllWorkspaceMetadata();
+          const found = all.find((m) => m.id === workspaceId);
+          return found ? Ok(found) : Err("not found");
+        }
+      ),
+      on: mock(() => undefined),
+      off: mock(() => undefined),
     } as unknown as AIService;
 
     const resumeStream = mock(() => Promise.resolve(Ok(undefined)));
@@ -251,15 +242,12 @@ describe("TaskService", () => {
       sendMessage: mock(() => Promise.resolve(Ok(undefined))),
       resumeStream,
       remove: mock(() => Promise.resolve(Ok(undefined))),
-      // eslint-disable-next-line @typescript-eslint/no-empty-function
       emit: mock(() => true),
     } as unknown as WorkspaceService;
 
     const initStateManager: InitStateManager = {
-      // eslint-disable-next-line @typescript-eslint/no-empty-function
-      startInit: mock(() => {}),
-      // eslint-disable-next-line @typescript-eslint/no-empty-function
-      appendOutput: mock(() => {}),
+      startInit: mock(() => undefined),
+      appendOutput: mock(() => undefined),
       endInit: mock(() => Promise.resolve()),
     } as unknown as InitStateManager;
 
@@ -311,9 +299,7 @@ describe("TaskService", () => {
       .flatMap((p) => p.workspaces)
       .find((w) => w.id === queued.data.taskId);
     expect(started?.taskStatus).toBe("running");
-    },
-    20_000
-  );
+  }, 20_000);
 
   test("agent_report posts report to parent, finalizes pending task tool output, and triggers cleanup", async () => {
     const config = new Config(rootDir);
@@ -386,10 +372,8 @@ describe("TaskService", () => {
 
     const aiService: AIService = {
       isStreaming: mock(() => false),
-      // eslint-disable-next-line @typescript-eslint/no-empty-function
-      on: mock(() => {}),
-      // eslint-disable-next-line @typescript-eslint/no-empty-function
-      off: mock(() => {}),
+      on: mock(() => undefined),
+      off: mock(() => undefined),
     } as unknown as AIService;
 
     const sendMessage = mock(() => Promise.resolve(Ok(undefined)));
@@ -405,10 +389,8 @@ describe("TaskService", () => {
     } as unknown as WorkspaceService;
 
     const initStateManager: InitStateManager = {
-      // eslint-disable-next-line @typescript-eslint/no-empty-function
-      startInit: mock(() => {}),
-      // eslint-disable-next-line @typescript-eslint/no-empty-function
-      appendOutput: mock(() => {}),
+      startInit: mock(() => undefined),
+      appendOutput: mock(() => undefined),
       endInit: mock(() => Promise.resolve()),
     } as unknown as InitStateManager;
 
@@ -422,17 +404,33 @@ describe("TaskService", () => {
     );
 
     const internal = taskService as unknown as {
-      handleAgentReport: (event: { type: "tool-call-end"; workspaceId: string; toolName: string }) => Promise<void>;
+      handleAgentReport: (event: {
+        type: "tool-call-end";
+        workspaceId: string;
+        toolName: string;
+      }) => Promise<void>;
     };
-    await internal.handleAgentReport({ type: "tool-call-end", workspaceId: childId, toolName: "agent_report" });
+    await internal.handleAgentReport({
+      type: "tool-call-end",
+      workspaceId: childId,
+      toolName: "agent_report",
+    });
 
     const parentHistory = await historyService.getHistory(parentId);
     expect(parentHistory.success).toBe(true);
     if (parentHistory.success) {
       const combined = parentHistory.data
         .filter((m) => m.role === "assistant")
         .flatMap((m) => m.parts)
-        .map((p) => (p && typeof p === "object" && "type" in p && (p as { type?: unknown }).type === "text" && "text" in p ? (p as { text?: unknown }).text : ""))
+        .map((p) =>
+          p &&
+          typeof p === "object" &&
+          "type" in p &&
+          (p as { type?: unknown }).type === "text" &&
+          "text" in p
+            ? (p as { text?: unknown }).text
+            : ""
+        )
         .join("");
       expect(combined).toContain("Hello from child");
     }
@@ -441,7 +439,11 @@ describe("TaskService", () => {
     expect(updatedParentPartial).not.toBeNull();
     if (updatedParentPartial) {
       const toolPart = updatedParentPartial.parts.find(
-        (p) => p && typeof p === "object" && "type" in p && (p as { type?: unknown }).type === "dynamic-tool"
+        (p) =>
+          p &&
+          typeof p === "object" &&
+          "type" in p &&
+          (p as { type?: unknown }).type === "dynamic-tool"
       ) as unknown as
         | {
             toolName: string;
@@ -529,10 +531,8 @@ describe("TaskService", () => {
 
     const aiService: AIService = {
       isStreaming: mock(() => false),
-      // eslint-disable-next-line @typescript-eslint/no-empty-function
-      on: mock(() => {}),
-      // eslint-disable-next-line @typescript-eslint/no-empty-function
-      off: mock(() => {}),
+      on: mock(() => undefined),
+      off: mock(() => undefined),
     } as unknown as AIService;
 
     const sendMessage = mock(() => Promise.resolve(Ok(undefined)));
@@ -548,10 +548,8 @@ describe("TaskService", () => {
     } as unknown as WorkspaceService;
 
     const initStateManager: InitStateManager = {
-      // eslint-disable-next-line @typescript-eslint/no-empty-function
-      startInit: mock(() => {}),
-      // eslint-disable-next-line @typescript-eslint/no-empty-function
-      appendOutput: mock(() => {}),
+      startInit: mock(() => undefined),
+      appendOutput: mock(() => undefined),
       endInit: mock(() => Promise.resolve()),
     } as unknown as InitStateManager;
 
@@ -585,7 +583,15 @@ describe("TaskService", () => {
       const combined = parentHistory.data
         .filter((m) => m.role === "assistant")
         .flatMap((m) => m.parts)
-        .map((p) => (p && typeof p === "object" && "type" in p && (p as { type?: unknown }).type === "text" && "text" in p ? (p as { text?: unknown }).text : ""))
+        .map((p) =>
+          p &&
+          typeof p === "object" &&
+          "type" in p &&
+          (p as { type?: unknown }).type === "text" &&
+          "text" in p
+            ? (p as { text?: unknown }).text
+            : ""
+        )
         .join("");
       expect(combined).toContain("Final output without agent_report");
       expect(combined).toContain("fallback");
@@ -595,7 +601,11 @@ describe("TaskService", () => {
     expect(updatedParentPartial).not.toBeNull();
     if (updatedParentPartial) {
       const toolPart = updatedParentPartial.parts.find(
-        (p) => p && typeof p === "object" && "type" in p && (p as { type?: unknown }).type === "dynamic-tool"
+        (p) =>
+          p &&
+          typeof p === "object" &&
+          "type" in p &&
+          (p as { type?: unknown }).type === "dynamic-tool"
       ) as unknown as
         | {
             toolName: string;
diff --git a/src/node/services/taskService.ts b/src/node/services/taskService.ts
diff --git a/src/node/services/tools/agent_report.ts b/src/node/services/tools/agent_report.ts
diff --git a/src/node/services/tools/task.test.ts b/src/node/services/tools/task.test.ts

Original file line number	Diff line number	Diff line change
`@@ -27,8 +27,7 @@ function clampInt(value: unknown, fallback: number, min: number, max: number): n`
`27`	`27`	`}`
`28`	`28`
`29`	`29`	`export function normalizeTaskSettings(raw: unknown): TaskSettings {`
`30`		`- const record =`
`31`		`- raw && typeof raw === "object" ? (raw as Record<string, unknown>) : ({} as const);`
	`30`	`+ const record = raw && typeof raw === "object" ? (raw as Record<string, unknown>) : ({} as const);`
`32`	`31`
`33`	`32`	`const maxParallelAgentTasks = clampInt(`
`34`	`33`	`record.maxParallelAgentTasks,`
`@@ -59,4 +58,3 @@ export function normalizeTaskSettings(raw: unknown): TaskSettings {`
`59`	`58`
`60`	`59`	`return result;`
`61`	`60`	`}`
`62`		`-`
Original file line number	Diff line number	Diff line change
`@@ -80,4 +80,3 @@ export function getAgentPreset(agentType: string \| undefined): AgentPreset \| nul`
`80`	`80`	`const normalized = (agentType ?? "").trim().toLowerCase();`
`81`	`81`	`return PRESETS_BY_AGENT_TYPE[normalized] ?? null;`
`82`	`82`	`}`
`83`		`-`