Skip to content

[PWGCF] FemtoUniverse: Remove error and potential bug #14360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prchakra merged 1 commit into from
Dec 29, 2025
Merged

[PWGCF] FemtoUniverse: Remove error and potential bug #14360

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions PWGCF/FemtoUniverse/Core/FemtoUniverseMath.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

#include "Math/Boost.h"
#include "Math/Vector4D.h"
#include "TLorentzVector.h"

Check failure on line 24 in PWGCF/FemtoUniverse/Core/FemtoUniverseMath.h

View workflow job for this annotation

GitHub Actions / O2 linter

[root/lorentz-vector] 

Do not use the TLorentzVector legacy class. Use std::array with RecoDecay methods or the ROOT::Math::LorentzVector template instead.
#include "TMath.h"

#include <algorithm>
Expand Down Expand Up @@ -255,7 +255,6 @@
}

if (isiden && isWeight) {

const double x1_lcms = (vecspace_part1.x() * tPx + vecspace_part1.y() * tPy) / tPt;
const double y1_lcms = (-vecspace_part1.x() * tPy + vecspace_part1.y() * tPx) / tPt;
const double x2_lcms = (vecspace_part2.x() * tPx + vecspace_part2.y() * tPy) / tPt;
Expand All @@ -271,8 +270,10 @@
const double mRL = (z1_lcms - z2_lcms) / 0.197327;
const double mDT = (t1_lcms - t2_lcms) / 0.197327;

const double quantumweight = 1.0 + TMath::Cos(-fDKOutLCMS * mRO - fDKSideLCMS * mRS - fDKLongLCMS * mRL + mDE * mDT);
const double quantumweight = 1.0 + std::cos(-fDKOutLCMS * mRO - fDKSideLCMS * mRS - fDKLongLCMS * mRL + mDE * mDT);
vect.push_back(quantumweight);
} else {
vect.push_back(1.0);
}
return vect;
}
Expand Down
Loading