Feature/burninate env api property #2799
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danoswaltCL
requested review from
bcb37,
Copilot and
zackcl
and removed request for
bcb37 and
Copilot
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the API endpoint management by removing the api property from all environment configuration files and centralizing API endpoint paths into a single, reusable constant file.
Key Changes:
- Created a new
API_ENDPOINTSconstant inapi-endpoints.constants.tscontaining all API endpoint paths - Removed the
apiproperty andAPIEndpointsinterface from environment configuration files - Updated all data services to import and use
API_ENDPOINTSinstead of injecting environment for API paths - Updated corresponding test files to remove environment dependency for API endpoints
Reviewed changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
frontend/projects/upgrade/src/app/core/api-endpoints.constants.ts |
New file containing centralized API endpoint paths as a const object |
frontend/projects/upgrade/src/environments/environment-types.ts |
Removed APIEndpoints interface and api property from Environment interface |
frontend/projects/upgrade/src/environments/environment.ts |
Removed api object containing 62 endpoint definitions |
frontend/projects/upgrade/src/environments/environment.staging.ts |
Removed api object containing 62 endpoint definitions |
frontend/projects/upgrade/src/environments/environment.qa.ts |
Removed api object containing 62 endpoint definitions |
frontend/projects/upgrade/src/environments/environment.prod.ts |
Removed api object containing 62 endpoint definitions |
frontend/projects/upgrade/src/environments/environment.local.example.ts |
Removed api object containing 62 endpoint definitions |
frontend/projects/upgrade/src/environments/environment.demo.prod.ts |
Removed api object containing 62 endpoint definitions |
frontend/projects/upgrade/src/environments/environment.bsnl.ts |
Removed api object containing 62 endpoint definitions |
frontend/projects/upgrade/src/app/core/version/version.service.ts |
Updated to use API_ENDPOINTS instead of injecting environment |
frontend/projects/upgrade/src/app/core/version/version.service.spec.ts |
Updated test to use API_ENDPOINTS and removed environment mock |
frontend/projects/upgrade/src/app/core/users/users.data.service.ts |
Updated to use API_ENDPOINTS instead of injecting environment |
frontend/projects/upgrade/src/app/core/users/users.data.service.spec.ts |
Updated test to use API_ENDPOINTS and removed environment mock |
frontend/projects/upgrade/src/app/core/stratification-factors/stratification-factors.data.service.ts |
Updated to use API_ENDPOINTS instead of injecting environment |
frontend/projects/upgrade/src/app/core/stratification-factors/stratification-factors.data.service.spec.ts |
Updated test to use API_ENDPOINTS and removed environment mock |
frontend/projects/upgrade/src/app/core/settings/settings.data.service.ts |
Updated to use API_ENDPOINTS instead of injecting environment |
frontend/projects/upgrade/src/app/core/settings/settings.data.service.spec.ts |
Updated test to use API_ENDPOINTS and removed environment mock |
frontend/projects/upgrade/src/app/core/segments/segments.data.service.ts |
Updated to use API_ENDPOINTS instead of injecting environment |
frontend/projects/upgrade/src/app/core/segments/segments.data.service.spec.ts |
Updated test to use API_ENDPOINTS and removed environment mock |
frontend/projects/upgrade/src/app/core/preview-users/preview-users.data.service.ts |
Updated to use API_ENDPOINTS instead of injecting environment |
frontend/projects/upgrade/src/app/core/preview-users/preview-users.data.service.spec.ts |
Updated test to use API_ENDPOINTS and removed environment mock |
frontend/projects/upgrade/src/app/core/logs/logs.data.service.ts |
Updated to use API_ENDPOINTS instead of injecting environment |
frontend/projects/upgrade/src/app/core/logs/logs.data.service.spec.ts |
Updated test to use API_ENDPOINTS and removed environment mock |
frontend/projects/upgrade/src/app/core/feature-flags/feature-flags.data.service.ts |
Updated to use API_ENDPOINTS instead of injecting environment |
frontend/projects/upgrade/src/app/core/experiments/experiments.data.service.ts |
Updated to use API_ENDPOINTS instead of injecting environment |
frontend/projects/upgrade/src/app/core/experiments/experiments.data.service.spec.ts |
Updated test to use API_ENDPOINTS and removed environment mock |
frontend/projects/upgrade/src/app/core/auth/auth.data.service.ts |
Updated to use API_ENDPOINTS instead of injecting environment |
frontend/projects/upgrade/src/app/core/analysis/analysis.data.service.ts |
Updated to use API_ENDPOINTS instead of injecting environment |
frontend/projects/upgrade/src/app/core/analysis/analysis.data.service.spec.ts |
Updated test to use API_ENDPOINTS and removed environment mock |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
frontend/projects/upgrade/src/app/core/feature-flags/feature-flags.data.service.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.