Skip to content

Conversation

@Muhtasham
Copy link
Contributor

Summary

Changes

  • codeclash/arenas/figgie/ - Arena implementation
  • configs/test/figgie.yaml - Test config
  • tests/arenas/test_figgie.py - Unit tests (6 tests)

Game Overview

Figgie simulates commodities trading where players buy/sell cards to accumulate the goal suit. The goal suit is secret until game end.

Test plan

  • 103 arena tests passing
  • Figgie game repo has 42 tests passing
  • Verified against official rules from figgie.com

- Use 'ask' instead of 'offer' action type
- Add state description with order book interface
- Document simultaneous tick trading model
- Support both 4 and 5 player games
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for Figgie, Jane Street's open-outcry trading card game, as a new arena in the CodeClash platform. Figgie simulates commodities trading where 4-5 players buy and sell cards to accumulate a secret goal suit.

Key Changes

  • New Figgie arena implementation following established patterns from Gomoku and Bridge arenas
  • Complete test suite with 6 unit tests covering validation and player count requirements
  • Configuration file and Docker setup for the game environment

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
codeclash/arenas/figgie/figgie.py Main Figgie arena implementation with validation, game execution, and results parsing
codeclash/arenas/figgie/Figgie.Dockerfile Docker configuration to set up Python 3.10 and clone the Figgie game repository
codeclash/arenas/__init__.py Registers FiggieArena in the arena module exports
tests/arenas/test_figgie.py Unit tests for Figgie validation logic and player count requirements
configs/test/figgie.yaml Test configuration with game rules and state documentation for 4 players
codeclash/arenas/bridge/bridge.py Code cleanup: removed unused import, consistent formatting, quote standardization
codeclash/arenas/gomoku/gomoku.py Formatting improvements for consistency (line wrapping, trailing commas)
tests/arenas/test_bridge.py Minor formatting cleanup (removed blank line, consistent line wrapping)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@john-b-yang john-b-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@john-b-yang
Copy link
Contributor

john-b-yang commented Dec 31, 2025

Great job with Figgie @Muhtasham! Implementation looks very good, I just made a minor tweak of adding a -o so that per-sim logs are also output.

Thanks as well for going through the effort of writing a Figgie implementation from the ground up! It does look like there's not really a great open-source implementation.

@john-b-yang john-b-yang merged commit 34a936e into CodeClash-ai:main Dec 31, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants