-
Notifications
You must be signed in to change notification settings - Fork 0
Feat/fix face depth #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements face depth functionality and refactors the face detection testing infrastructure. The changes move from hardcoded test expectations to file-based test data storage and add comprehensive face depth testing capabilities.
Key changes:
- Replaces inline test data with NPZ file-based test expectations for better maintainability
- Adds complete face depth testing module with batch processing support
- Fixes batch size handling bug in multiple face processing components
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_face_detection.py | Refactored to use NPZ files for test data and added batch testing |
| tests/test_face_depth.py | New comprehensive test suite for face depth functionality |
| tests/resources/answer/*.npz | Git LFS tracked test data files for face detection and depth |
| pyface/utils.py | Removed deprecated backend detection utilities |
| pyface/components/face_recognition/arcface.py | Fixed batch size variable naming for clarity |
| pyface/components/face_gender.py | Fixed batch size variable naming for clarity |
| pyface/components/face_detection/scrfd.py | Fixed batch size variable naming for clarity |
| pyface/components/face_depth/tddfav2.py | Fixed batch processing, type hints, and data handling |
| .gitattributes | Added NPZ files to Git LFS tracking |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
f95a3b1 to
a65310e
Compare
5c9b1a4 to
29ce54b
Compare
29ce54b to
878ec79
Compare
9bed373 to
21f86c0
Compare
21f86c0 to
5daed92
Compare
|
This pull request introduces several improvements and refactoring across demo scripts, CI workflows, and core components. The main focus is on standardizing resource paths in demo scripts, enhancing the CI pipeline (especially for CUDA builds), fixing batch handling in model inference, and updating Dockerfile configurations for compatibility and maintainability. Demo script improvements:
CI/CD and Dockerfile enhancements:
Core component bug fixes and refactoring:
Repository maintenance:
|
!!! Git lfs unstable in container