PHP 8.4 #31
Merged
PHP 8.4 #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because it's been a very long time since it was useful for us. Code coverage statistics over time is the last interesting bit, but not worth the extra computing and maintenance cost.
There was a problem hiding this comment.
Pull request overview
This PR upgrades the project to support PHP 8.5 (pre-release) by updating the minimum PHP version requirement, modernizing test infrastructure with PHPUnit attributes, updating dependencies, and removing Scrutinizer CI integration in favor of GitHub Actions-only CI.
Key Changes:
- Upgraded minimum PHP version from 8.2 to 8.4 with 8.5 testing support
- Migrated PHPUnit test annotations to PHP 8 attributes (DataProvider)
- Updated major dependencies including PHPUnit 9→12, PHPStan 1.9→2.1, and related packages
- Removed Scrutinizer CI integration and badges
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| composer.json | Updated PHP requirement to ^8.4 and dependency version constraints |
| composer.lock | Comprehensive dependency updates reflecting new version requirements |
| tests/UploadTypeTest.php | Migrated @dataProvider annotation to #[DataProvider] attribute |
| phpunit.xml.dist | Updated PHPUnit configuration schema and modernized cache/source syntax |
| phpstan.neon.dist | Changed PHPStan level from 'max' to '8' |
| .github/workflows/main.yml | Updated CI matrix to test PHP 8.4 and 8.5, removed coverage job |
| README.md | Removed Scrutinizer CI badges |
| .scrutinizer.yml | Deleted Scrutinizer CI configuration file |
| .gitattributes | Removed .scrutinizer.yml from export-ignore list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.