drivers: make use of xtimer to simplify code #21959
Open
+6
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpicco
added
the
CI: ready for build
Member
|
That is indeed a lot simpler. Can we also just remove the actual E.g. also stuff like |
crasbe
added
the
Type: cleanup
Contributor
|
This does simplify the driver quite a bit. The only thing is, xtimer is deprecated. Shouldn't this go the other way, and move to ztimer only? |
Contributor
Author
Only the xtimer implementation is deprecated and can be removed (#21960)
We definitely don't want to add more of this clutter to the codebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
xtimer_compat.hnow always provides an xtimer implementation, even if no timer backend is used at all (then falls back to busy waiting).This means we can use the xtimer API as a zero-cost abstraction to any timer backend wherever no particular timer is required.
Testing procedure
No changes in code expected when the existing ztimer backends are used.
Issues/PRs references
based on #20494