Build shared library directly #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hmm CI still isn't running... |
Member
|
We should remove |
Member
|
|
emmatyping
force-pushed
the
3.15-generate-a-shared-lib-from-crate
branch
from
d013390 to
dbd7a39
Compare
This commit modifies the build system to directly generate shared objects rather than generating a static library that is linked to libpython into a shared object. The downside is that we should probably figure out a way to handle custom linker flags and customization of `BLDSHARED`.
emmatyping
force-pushed
the
3.15-generate-a-shared-lib-from-crate
branch
from
003c45b to
f019d93
Compare
Author
|
macOS/Android/iOS all seem to be failing at symbols being undefined. I wonder if the way I am pulling in |
Author
|
Ah I should probably also handle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modifies the build system to directly generate shared objects rather than generating a static library that is linked to libpython into a shared object. This removes the link hack that we currently use.
The downside is that we should probably figure out a way to handle custom linker flags and customization of
BLDSHARED.