homepage image endpoint + random image on home screen #1978
+63
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanugarte
reviewed
Dec 30, 2025
| const { OK, NOT_FOUND } = require('../../util/constants').STATUS_CODES; | ||
| const { getRandomImageUrl } = require('../util/HomepageImages'); | ||
|
|
||
| router.get('/image', (req, res) => { |
Collaborator
There was a problem hiding this comment.
can we change this file to be image.js and the endpoint /homepage?
that way we can do /image/homepage, and later we can reuse this file for /image/projects
| @@ -0,0 +1,16 @@ | |||
| //sample images (all from openverse.org) for now!! | |||
| const imageUrls = [ | |||
Collaborator
There was a problem hiding this comment.
lets put this in the routes file, its not much codee
and can we change the description field to alt and return the entire object (url and alt) as the api response
| <img | ||
| className="w-full mx-auto transform md:w-4/5 rounded-xl" | ||
| src="https://raw.githubusercontent.com/thebeninator/Clark/refs/heads/add_comp_homepage/public/images/compressed2.jpg" | ||
| src={homeImageUrl} |
Collaborator
There was a problem hiding this comment.
we can use the .url field here, and add an alt tag using the api response
Comment on lines
+26
to
+34
| async function loadHomeImage() { | ||
| const response = await getHomeImageUrl(); | ||
| const url = response.responseData; | ||
| if (!response.error && url) { | ||
| setHomeImageUrl(url.trim()); | ||
| } else { //old image if error | ||
| setHomeImageUrl('https://raw.githubusercontent.com/thebeninator/Clark/refs/heads/add_comp_homepage/public/images/compressed2.jpg'); | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
how about something like
async function loadHomeImage() {
const DEFAULT_IMAGE = 'https://raw.githubusercontent.com/thebeninator/Clark/refs/heads/add_comp_homepage/public/images/compressed2.jpg';
const response = await getHomeImageUrl();
let url = DEFAULT_IMAGE;
let alt = 'sce club image';
if (!response.error) {
url = response.responseData.url;
alt = response.responseData.alt;
}
setHomeImageUrl(url);
setAltText(alt); // need to add new alt field
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for issue #1952
has random images i found online for now