bugfix/stop-all-multi-request-bug #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- First, a potential memory leak. If requests were made, but never canceled the TokenManagementService.cs would indefinitely add to that list taking up memory it doesn't need. And when eventually cancelled it could cause further issues. Now, after a command completes, it is cleaned up with the management service. As it should be. - Secondly, if a command is stopped mid execution it has the potential to be left where the state is still the opposite. So, when the TokenManagementService.cs attempts to cancel and return it to the original state, it gets the value wrong. This fixes that bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.