Skip to content

Fix navigation drawer highlighting incorrect menu item after language/theme change #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
314systems wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −1
Open

Fix navigation drawer highlighting incorrect menu item after language/theme change #580

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/src/main/res/layout/main_activity.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,10 @@
android:layout_height="match_parent"
android:layout_gravity="start"
android:fitsSystemWindows="true"
android:saveEnabled="false"
Copy link

Copilot AI Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix correctly disables automatic state restoration for the NavigationView, which prevents conflicts with the app's manual state management in MainActivity.onCreate(). However, there is no automated test coverage for this navigation state restoration behavior after activity recreation. Consider adding an instrumentation test that verifies the navigation drawer highlights the correct menu item after the activity is recreated due to a configuration change like language or theme change.

Copilot uses AI. Check for mistakes.
app:headerLayout="@layout/main_navigation"
app:itemIconTint="@drawable/menu_selector"
app:itemTextColor="@drawable/menu_selector"
app:menu="@menu/nav_drawer_menu" />

</androidx.drawerlayout.widget.DrawerLayout>
</androidx.drawerlayout.widget.DrawerLayout>
Loading