Skip to content

Conversation

@rahulgoswami
Copy link
Contributor

@rahulgoswami rahulgoswami commented Dec 28, 2025

Description

The factory name is LatestVersionMergePolicyFactory, whereas the policy is named LatestVersionFilterMergePolicy. Also the name indicating it’s a FilterMergePolicy is really an implementation detail we can do away with.

Solution

Rename LatestVersionFilterMergePolicy to LatestVersionMergePolicy.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide
  • I have added a changelog entry for my change

@rahulgoswami
Copy link
Contributor Author

rahulgoswami commented Dec 28, 2025

@dsmiley @gerlowskija Mind taking a look please? Thanks.

@rahulgoswami
Copy link
Contributor Author

rahulgoswami commented Dec 28, 2025

fwiw this merge policy is currently merged but unreleased across branch_9x, branch_10x and branch_10_0, so should be a safe change.

@rahulgoswami rahulgoswami changed the title Rename LatestVersionMergePolicy for more intuitive naming compatibility with the factory Rename LatestVersionMergePolicy for a more intuitive name compatibility with the factory Dec 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant