fix(xpc): prevent startup hangs with proper timeout handling (#561) #995
+19
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add timeout to XPCClient.send() that cancels connection on expiry - Use .timeout error code with helpful message suggesting system start - Skip blocking default network creation during apiserver startup - Add 5-second timeouts to all NetworkClient XPC calls - Fix NetworksService init to continue on network failure, not return
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
The apiserver could hang indefinitely during startup if the vmnet plugin failed or was unresponsive. XPC calls now have proper timeout handling that cancels the connection on expiry and returns a helpful error message. The apiserver no longer blocks on default network creation during startup, and NetworkClient XPC calls have 5-second timeouts. Additionally, NetworksService initialization now continues processing remaining networks when one fails instead of returning early.
container system startwould hang on startup waiting for the apiserver.Testing