fix(registry): grant keychain access to images plugin (#816) #997
+71
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When saving registry credentials, use the security CLI with -T flags to grant keychain access to both the container CLI and container-core-images plugin. Previously, credentials saved via SecItemAdd only allowed access from the creating binary, causing error -25308 when the images plugin tried to read credentials for private registries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When saving registry credentials, use the security CLI with -T flags to grant keychain access to both the container CLI and container-core-images plugin. Previously, credentials saved via SecItemAdd only allowed access from the creating binary, causing error -25308 when the images plugin tried to read credentials for private registries.
Type of Change
Motivation and Context
Registry credentials saved via container login were inaccessible to the container-core-images plugin, causing error -25308 when pulling from private registries. The fix uses the security CLI with -T flags to grant keychain access to both the container CLI and the images plugin binary, ensuring credentials work correctly across all container operations.
Testing