DevTree overlays to enable RK3308 UARTS #9072
Merged
+113
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentr
requested review from
ColorfulRhino,
HeyMeco,
JohnTheCoolingFan,
SuperKali,
TheSnowfield,
Tonymac32,
ahoneybun,
amazingfate,
catalinii,
chainsx,
efectn,
igorpecovnik,
joekhoobyar,
krachlatte,
lanefu,
paolosabatino,
prahal,
pyavitz,
rpardini and
schwar3kat
as code owners
Contributor
WalkthroughAdds three device tree overlays (UART1, UART2, UART3) for RK3308 across kernel versions 6.12 and 6.18. Updates Makefiles to include the new device tree binary overlays, adds corresponding device tree source files to enable each UART interface, and updates documentation with overlay details and usage notes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
bot
added
size/medium
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
patch/kernel/archive/rockchip64-6.18/overlay/rk3308-uart1.dtso (1)
1-13: UART1 overlay is minimal and correctStandard plugin fragment that just flips
&uart1tostatus = "okay";; this matches existing Rockchip overlay patterns and should be safe.Minor style nit: consider changing the file header comment to something like
// Enable RK3308 UART1(note the space) or a/* ... */comment, and applying the same convention across all rk3308-uart*.dtso overlays in this PR for consistency.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (10)
patch/kernel/archive/rockchip64-6.12/overlay/Makefile(1 hunks)patch/kernel/archive/rockchip64-6.12/overlay/README.rockchip-overlays(2 hunks)patch/kernel/archive/rockchip64-6.12/overlay/rk3308-uart1.dtso(1 hunks)patch/kernel/archive/rockchip64-6.12/overlay/rk3308-uart2.dtso(1 hunks)patch/kernel/archive/rockchip64-6.12/overlay/rk3308-uart3.dtso(1 hunks)patch/kernel/archive/rockchip64-6.18/overlay/Makefile(1 hunks)patch/kernel/archive/rockchip64-6.18/overlay/README.rockchip-overlays(2 hunks)patch/kernel/archive/rockchip64-6.18/overlay/rk3308-uart1.dtso(1 hunks)patch/kernel/archive/rockchip64-6.18/overlay/rk3308-uart2.dtso(1 hunks)patch/kernel/archive/rockchip64-6.18/overlay/rk3308-uart3.dtso(1 hunks)
🧰 Additional context used
🧠 Learnings (19)
📓 Common learnings
Learnt from: EvilOlaf
Repo: armbian/build PR: 8428
File: config/boards/lckfb-taishanpi.csc:5-9
Timestamp: 2025-07-25T03:51:50.830Z
Learning: When reviewing PRs in the Armbian build system, U-Boot defconfig files and patches may be added as part of the PR changes but might not be visible in the current repository clone state during review. It's important to check the actual PR file changes directly via GitHub or the PR API to get the complete picture of what files are being added or modified.
Learnt from: EvilOlaf
Repo: armbian/build PR: 8428
File: config/boards/lckfb-taishanpi.csc:5-9
Timestamp: 2025-07-25T03:51:50.830Z
Learning: When reviewing PRs in the Armbian build system, U-Boot defconfig files and patches may be added as part of the PR changes but might not be visible in the current repository clone state during review. It's important to check the actual PR file changes directly via GitHub API (https://api.github.com/repos/armbian/build/pulls/{pr_number}/files) to get the complete picture of what files are being added or modified, especially for U-Boot patches that will be applied during the build process.
Learnt from: SuperKali
Repo: armbian/build PR: 8936
File: patch/kernel/archive/rockchip64-6.18/dt/rk3576-nanopi-r76s.dts:800-802
Timestamp: 2025-11-15T14:33:30.654Z
Learning: In RK3576 device tree files (like rk3576-nanopi-r76s.dts), the serial0 alias is already defined in the upstream kernel's rk3576.dtsi base file, so board-specific DTS files do not need to redeclare it when enabling &uart0 for serial console.
Learnt from: amazingfate
Repo: armbian/build PR: 8619
File: config/sources/families/rockchip.conf:222-230
Timestamp: 2025-09-14T06:32:29.806Z
Learning: In the Armbian build system, the write_uboot_platform() function implementations follow different patterns across Rockchip family files. The newer standard (used in rockchip64_common.inc and rk3506) includes 'status=none' parameter in dd commands, while older implementations (rk3288, rk322x) use an older pattern without this parameter. The rk3506 implementation correctly follows the current Rockchip family standard.
Learnt from: EvilOlaf
Repo: armbian/build PR: 8886
File: patch/kernel/rk35xx-vendor-6.1/dt/rk3528-nanopi-rev01.dts:9-9
Timestamp: 2025-11-08T06:39:24.527Z
Learning: In Armbian's Rockchip vendor kernel branches (rk35xx-vendor), device tree files may not require the same headers as mainline Linux. For example, input key definitions like KEY_BACK and KEY_VOLUMEUP may be handled differently in BSP kernels and don't necessarily need explicit includes like <dt-bindings/input/input.h> that would be required in mainline kernel device trees.
📚 Learning: 2025-11-15T14:33:30.654Z
Learnt from: SuperKali
Repo: armbian/build PR: 8936
File: patch/kernel/archive/rockchip64-6.18/dt/rk3576-nanopi-r76s.dts:800-802
Timestamp: 2025-11-15T14:33:30.654Z
Learning: In RK3576 device tree files (like rk3576-nanopi-r76s.dts), the serial0 alias is already defined in the upstream kernel's rk3576.dtsi base file, so board-specific DTS files do not need to redeclare it when enabling &uart0 for serial console.
Applied to files:
patch/kernel/archive/rockchip64-6.12/overlay/rk3308-uart1.dtsopatch/kernel/archive/rockchip64-6.18/overlay/rk3308-uart2.dtsopatch/kernel/archive/rockchip64-6.12/overlay/Makefilepatch/kernel/archive/rockchip64-6.18/overlay/rk3308-uart1.dtsopatch/kernel/archive/rockchip64-6.18/overlay/rk3308-uart3.dtsopatch/kernel/archive/rockchip64-6.12/overlay/README.rockchip-overlayspatch/kernel/archive/rockchip64-6.12/overlay/rk3308-uart2.dtsopatch/kernel/archive/rockchip64-6.12/overlay/rk3308-uart3.dtsopatch/kernel/archive/rockchip64-6.18/overlay/README.rockchip-overlayspatch/kernel/archive/rockchip64-6.18/overlay/Makefile
📚 Learning: 2025-09-14T06:32:29.806Z
Learnt from: amazingfate
Repo: armbian/build PR: 8619
File: config/sources/families/rockchip.conf:222-230
Timestamp: 2025-09-14T06:32:29.806Z
Learning: In the Armbian build system, the write_uboot_platform() function implementations follow different patterns across Rockchip family files. The newer standard (used in rockchip64_common.inc and rk3506) includes 'status=none' parameter in dd commands, while older implementations (rk3288, rk322x) use an older pattern without this parameter. The rk3506 implementation correctly follows the current Rockchip family standard.
Applied to files:
patch/kernel/archive/rockchip64-6.12/overlay/rk3308-uart1.dtsopatch/kernel/archive/rockchip64-6.18/overlay/rk3308-uart2.dtsopatch/kernel/archive/rockchip64-6.12/overlay/Makefilepatch/kernel/archive/rockchip64-6.18/overlay/rk3308-uart1.dtsopatch/kernel/archive/rockchip64-6.18/overlay/rk3308-uart3.dtsopatch/kernel/archive/rockchip64-6.12/overlay/README.rockchip-overlayspatch/kernel/archive/rockchip64-6.12/overlay/rk3308-uart2.dtsopatch/kernel/archive/rockchip64-6.12/overlay/rk3308-uart3.dtsopatch/kernel/archive/rockchip64-6.18/overlay/README.rockchip-overlayspatch/kernel/archive/rockchip64-6.18/overlay/Makefile
📚 Learning: 2025-11-08T06:39:24.527Z
Learnt from: EvilOlaf
Repo: armbian/build PR: 8886
File: patch/kernel/rk35xx-vendor-6.1/dt/rk3528-nanopi-rev01.dts:9-9
Timestamp: 2025-11-08T06:39:24.527Z
Learning: In Armbian's Rockchip vendor kernel branches (rk35xx-vendor), device tree files may not require the same headers as mainline Linux. For example, input key definitions like KEY_BACK and KEY_VOLUMEUP may be handled differently in BSP kernels and don't necessarily need explicit includes like <dt-bindings/input/input.h> that would be required in mainline kernel device trees.
Applied to files:
patch/kernel/archive/rockchip64-6.12/overlay/rk3308-uart1.dtsopatch/kernel/archive/rockchip64-6.18/overlay/rk3308-uart2.dtsopatch/kernel/archive/rockchip64-6.12/overlay/Makefilepatch/kernel/archive/rockchip64-6.18/overlay/rk3308-uart1.dtsopatch/kernel/archive/rockchip64-6.18/overlay/rk3308-uart3.dtsopatch/kernel/archive/rockchip64-6.12/overlay/README.rockchip-overlayspatch/kernel/archive/rockchip64-6.12/overlay/rk3308-uart3.dtsopatch/kernel/archive/rockchip64-6.18/overlay/README.rockchip-overlayspatch/kernel/archive/rockchip64-6.18/overlay/Makefile
📚 Learning: 2025-11-20T18:20:11.985Z
Learnt from: EvilOlaf
Repo: armbian/build PR: 8968
File: patch/u-boot/u-boot-sunxi/arm64-dts-sun50i-h6-orangepi.dtsi-Rollback-r_rsb-to-r_i2c.patch:36-36
Timestamp: 2025-11-20T18:20:11.985Z
Learning: The rewrite-patches tool (REWRITE_PATCHES=yes) in the Armbian build system can inadvertently introduce semantic changes when the u-boot/kernel git base revision differs from expected state. The tool applies patches, commits them, and re-exports them using git format-patch, which can cause the re-exported patch to reflect the base revision's state rather than preserving the original patch intent. This is particularly problematic for device tree changes like interrupt specifications. The tool currently lacks validation mechanisms to detect such semantic drift, and affected patches must be manually corrected after rewriting.
Applied to files:
patch/kernel/archive/rockchip64-6.18/overlay/rk3308-uart2.dtsopatch/kernel/archive/rockchip64-6.12/overlay/Makefilepatch/kernel/archive/rockchip64-6.18/overlay/rk3308-uart3.dtsopatch/kernel/archive/rockchip64-6.12/overlay/README.rockchip-overlayspatch/kernel/archive/rockchip64-6.18/overlay/Makefile
📚 Learning: 2025-03-31T22:20:41.849Z
Learnt from: rpardini
Repo: armbian/build PR: 8044
File: patch/u-boot/v2025.04/cmd-fileenv-read-string-from-file-into-env.patch:73-75
Timestamp: 2025-03-31T22:20:41.849Z
Learning: When porting patches between U-Boot versions (like from 2025.01 to 2025.04), rpardini prefers to maintain patches as-is rather than introducing refactoring changes, even when potential improvements are identified. This approach prioritizes consistency and reduces the risk of introducing new issues.
Applied to files:
patch/kernel/archive/rockchip64-6.12/overlay/Makefilepatch/kernel/archive/rockchip64-6.12/overlay/README.rockchip-overlayspatch/kernel/archive/rockchip64-6.18/overlay/Makefile
📚 Learning: 2025-12-13T11:44:54.545Z
Learnt from: pyavitz
Repo: armbian/build PR: 9058
File: patch/u-boot/legacy/u-boot-spacemit-k1/003-SpacemiT-K1X-Fixups.patch:17-25
Timestamp: 2025-12-13T11:44:54.545Z
Learning: In the SpacemiT U-Boot patches for Armbian (patch/u-boot/legacy/u-boot-spacemit-k1/), the environment variable `devnum` is set to the device name string (e.g., "mmc", "nvme") rather than a numeric index, and `distro_bootpart` holds the partition number. This implementation aligns with mainline U-Boot conventions for the SpacemiT platform and has been verified to work correctly by the maintainer.
Applied to files:
patch/kernel/archive/rockchip64-6.12/overlay/Makefile
📚 Learning: 2025-12-13T11:38:58.965Z
Learnt from: pyavitz
Repo: armbian/build PR: 9058
File: patch/u-boot/legacy/u-boot-spacemit-k1/003-SpacemiT-K1X-Fixups.patch:28-67
Timestamp: 2025-12-13T11:38:58.965Z
Learning: In the Armbian build system for SpacemiT U-Boot patches (patch/u-boot/legacy/u-boot-spacemit-k1/), alignment with mainline U-Boot behavior is prioritized. For example, in boot mode handling, leaving devnum unchanged in the default case (when devtype is cleared) follows mainline conventions rather than explicitly clearing it to handle edge cases.
Applied to files:
patch/kernel/archive/rockchip64-6.12/overlay/Makefile
📚 Learning: 2025-07-23T07:30:52.265Z
Learnt from: EvilOlaf
Repo: armbian/build PR: 8417
File: config/boards/orangepi5pro.csc:57-58
Timestamp: 2025-07-23T07:30:52.265Z
Learning: In the Armbian build system, BOOTPATCHDIR can contain board-specific subdirectories (e.g., board_orangepi5pro) for applying patches to specific boards only. The framework automatically checks if such board-specific subdirectories exist for the board being built and applies those patches accordingly.
Applied to files:
patch/kernel/archive/rockchip64-6.12/overlay/Makefile
📚 Learning: 2025-08-30T04:13:16.457Z
Learnt from: tabrisnet
Repo: armbian/build PR: 0
File: :0-0
Timestamp: 2025-08-30T04:13:16.457Z
Learning: Armbian kernel configuration files like linux-filogic-current.config are autogenerated overlays on top of arch defconfig. Comments added manually will be lost during future updates by maintainers, and explicit "CONFIG_OPTION is not set" statements aren't needed for mutually exclusive options since these are overlay configs that only specify changes from the base configuration.
Applied to files:
patch/kernel/archive/rockchip64-6.12/overlay/Makefilepatch/kernel/archive/rockchip64-6.12/overlay/README.rockchip-overlayspatch/kernel/archive/rockchip64-6.18/overlay/README.rockchip-overlayspatch/kernel/archive/rockchip64-6.18/overlay/Makefile
📚 Learning: 2025-09-12T21:44:09.061Z
Learnt from: Grippy98
Repo: armbian/build PR: 8624
File: config/boards/sk-am62p.conf:8-8
Timestamp: 2025-09-12T21:44:09.061Z
Learning: For TI K3 family boards in Armbian, BOOT_FDT_FILE uses .dts extension (not .dtb) as the standard convention. The build system handles this correctly by automatically compiling .dts to .dtb during kernel build and using the BOOT_FDT_FILE value directly in bootloader configurations.
Applied to files:
patch/kernel/archive/rockchip64-6.12/overlay/Makefilepatch/kernel/archive/rockchip64-6.18/overlay/Makefile
📚 Learning: 2025-10-26T10:41:35.118Z
Learnt from: HackingGate
Repo: armbian/build PR: 8665
File: config/boards/photonicat2.csc:4-4
Timestamp: 2025-10-26T10:41:35.118Z
Learning: In the Armbian build system, rk3576 boards consistently use BOARDFAMILY="rk35xx" for both vendor and edge kernel targets. The rk35xx family configuration sources rockchip64_common.inc, which provides edge and current kernel branch definitions, making these branches available even though they're not defined directly in rk35xx.conf.
Applied to files:
patch/kernel/archive/rockchip64-6.12/overlay/Makefilepatch/kernel/archive/rockchip64-6.12/overlay/README.rockchip-overlayspatch/kernel/archive/rockchip64-6.18/overlay/README.rockchip-overlayspatch/kernel/archive/rockchip64-6.18/overlay/Makefile
📚 Learning: 2025-09-14T06:10:25.610Z
Learnt from: EvilOlaf
Repo: armbian/build PR: 8619
File: config/sources/families/rockchip.conf:64-70
Timestamp: 2025-09-14T06:10:25.610Z
Learning: In the Armbian build system, rk32xx and rk33xx Rockchip SoCs no longer have BSP-based (vendor) kernel branches. The rk3506 is the first 32-bit Rockchip SoC to use the vendor branch in the current codebase.
Applied to files:
patch/kernel/archive/rockchip64-6.12/overlay/Makefilepatch/kernel/archive/rockchip64-6.12/overlay/README.rockchip-overlayspatch/kernel/archive/rockchip64-6.18/overlay/Makefile
📚 Learning: 2025-11-10T23:44:53.363Z
Learnt from: tabrisnet
Repo: armbian/build PR: 0
File: :0-0
Timestamp: 2025-11-10T23:44:53.363Z
Learning: For the RV1106 family in Armbian (config/sources/families/rockchip-rv1106.conf), udev.children-max=1 is set in the kernel boot parameters to prevent early-boot OOM errors. The RV1106 has a single-core CPU, so parallelism in udev child processes provides no practical benefit. Testing higher values is impractical due to the difficulty of monitoring at this early boot stage.
Applied to files:
patch/kernel/archive/rockchip64-6.12/overlay/Makefilepatch/kernel/archive/rockchip64-6.18/overlay/Makefile
📚 Learning: 2025-10-22T07:51:53.015Z
Learnt from: igorpecovnik
Repo: armbian/build PR: 8789
File: config/kernel/linux-sunxi64-edge.config:839-839
Timestamp: 2025-10-22T07:51:53.015Z
Learning: In Armbian's wireless driver configuration, CONFIG_RK_WIFI_DEVICE_* options are Rockchip-specific device registration settings, while CONFIG_WLAN_UWE* are the actual cross-platform driver modules for UWE5622 wireless chips. The UWE5622 chip (manufactured by Unisoc/Spreadtrum) is used on multiple Allwinner boards including Orange Pi Zero 2/2W/3 and Orange Pi 3 LTS, so CONFIG_WLAN_UWE5621/5622 along with Unisoc infrastructure options (CONFIG_SPARD_WLAN_SUPPORT, CONFIG_SC23XX, CONFIG_UNISOC_WIFI_PS, CONFIG_WCN_BSP_DRIVER_BUILDIN) are correct in sunxi64 kernel configs.
Applied to files:
patch/kernel/archive/rockchip64-6.12/overlay/Makefilepatch/kernel/archive/rockchip64-6.12/overlay/README.rockchip-overlayspatch/kernel/archive/rockchip64-6.18/overlay/README.rockchip-overlayspatch/kernel/archive/rockchip64-6.18/overlay/Makefile
📚 Learning: 2025-09-18T03:36:17.862Z
Learnt from: EvilOlaf
Repo: armbian/build PR: 8537
File: config/boards/qcom-robotics-rb5.conf:1-1
Timestamp: 2025-09-18T03:36:17.862Z
Learning: In Armbian board configuration files (regardless of file extension), the standard pattern is to have only one line as a comment describing the board hardware specifications. This single-line description typically includes the SoC model, core count, RAM options, and key features like connectivity options, storage interfaces, and special features. The file extensions indicate board support status: .conf (standard support), .csc (community supported), .eos (end of support), .tvb (tvbox), .wip (work in progress).
Applied to files:
patch/kernel/archive/rockchip64-6.12/overlay/README.rockchip-overlays
📚 Learning: 2025-10-11T19:52:54.648Z
Learnt from: tabrisnet
Repo: armbian/build PR: 8746
File: config/kernel/linux-filogic-edge.config:344-470
Timestamp: 2025-10-11T19:52:54.648Z
Learning: The chainsx/linux-filogic kernel (legacy branch) for BPI-R4 uses out-of-tree proprietary drivers (CONFIG_NET_DSA_AN8855, CONFIG_AIROHA_EN8801SC_PHY, CONFIG_AIR_AN8855_PHY, CONFIG_MDIO_AN8855, CONFIG_MFD_AIROHA_AN8855). The frank-w/BPI-Router-Linux kernel (current and edge branches) uses mainline kernel drivers instead: CONFIG_NET_DSA_MT7530 for the DSA switch and CONFIG_MEDIATEK_2P5GE_PHY for PHY support. These provide equivalent functionality for BPI-R4 networking.
Applied to files:
patch/kernel/archive/rockchip64-6.12/overlay/README.rockchip-overlays
📚 Learning: 2025-09-14T06:29:18.958Z
Learnt from: amazingfate
Repo: armbian/build PR: 8619
File: config/sources/families/rockchip.conf:64-70
Timestamp: 2025-09-14T06:29:18.958Z
Learning: In the Armbian build system, vendor branch configurations in family files are designed to be shared across multiple SoCs within the same family that use the same vendor kernel tree. For example, rk35xx and rockchip-rk3588 families both use identical vendor branch settings (same KERNELSOURCE, KERNELBRANCH, and KERNELPATCHDIR), demonstrating that vendor branches are intentionally generic rather than SoC-specific.
Applied to files:
patch/kernel/archive/rockchip64-6.12/overlay/README.rockchip-overlays
📚 Learning: 2025-12-13T11:00:21.920Z
Learnt from: pyavitz
Repo: armbian/build PR: 9058
File: patch/kernel/archive/spacemit-6.6/dt/lcd_tc358762xbg_dpi_800x480.dtsi:3-61
Timestamp: 2025-12-13T11:00:21.920Z
Learning: On the SpacemiT MusePi Pro board with spacemit-6.6 kernel, LCD/DSI support is disabled in k1-musepi-pro.dts because enabling it causes the unit to lock up during boot. The lcd_tc358762xbg_dpi_800x480.dtsi file exists but DSI remains disabled at the controller level.
Applied to files:
patch/kernel/archive/rockchip64-6.18/overlay/README.rockchip-overlays
🔇 Additional comments (10)
patch/kernel/archive/rockchip64-6.18/overlay/Makefile (1)
5-5: RK3308 UART dtbo list entry looks correctThe three rk3308-uart{1,2,3}.dtbo entries are named and placed consistently with the surrounding RK3308 overlays; build integration looks fine.
patch/kernel/archive/rockchip64-6.12/overlay/rk3308-uart1.dtso (1)
1-13: 6.12 UART1 overlay matches 6.18 implementationThis overlay mirrors the 6.18 rk3308-uart1.dtso (plugin header, fragment@0 targeting
&uart1,status = "okay";), so behavior is consistent across kernel versions.patch/kernel/archive/rockchip64-6.12/overlay/rk3308-uart3.dtso (1)
1-13: UART3 enable overlay for 6.12 is straightforwardThe overlay cleanly targets
&uart3and setsstatus = "okay";using the standard fragment pattern; no issues spotted.patch/kernel/archive/rockchip64-6.12/overlay/rk3308-uart2.dtso (1)
1-13: UART2 enable overlay for 6.12 is consistent with othersStandard
/plugin/overlay that flips&uart2to"okay"; matches the uart1/uart3 overlays and should work as expected.patch/kernel/archive/rockchip64-6.18/overlay/rk3308-uart2.dtso (1)
1-13: 6.18 UART2 overlay mirrors 6.12 versionStructure and semantics match the 6.12 rk3308-uart2.dtso, giving consistent UART2 enable behavior across kernel versions.
patch/kernel/archive/rockchip64-6.18/overlay/rk3308-uart3.dtso (1)
1-13: UART3 overlay for 6.18 matches the established patternAnother minimal overlay that enables
&uart3viastatus = "okay";; consistent with the other rk3308 UART overlays.patch/kernel/archive/rockchip64-6.12/overlay/Makefile (1)
5-5: RK3308 UART dtbos correctly added for 6.12The rk3308-uart{1,2,3}.dtbo entries are added in the expected RK3308 section and mirror the 6.18 Makefile change, so both kernel series will build the new overlays.
patch/kernel/archive/rockchip64-6.12/overlay/README.rockchip-overlays (1)
13-14: UART overlay binaries are properly configured for building.All three RK3308 UART overlays (uart1, uart2, uart3) have corresponding source files and Makefile build entries. The overlay list update in the README is correct.
patch/kernel/archive/rockchip64-6.18/overlay/README.rockchip-overlays (2)
13-14: The three UART overlay source files exist and are properly configured.All UART overlays (uart1, uart2, uart3) for RK3308 have corresponding .dtso source files and .dtbo entries in the Makefile. The README documentation at lines 13-14 correctly lists these overlays.
18-29: The mksklipad overlay documentation sections in the README are pre-existing in the 6.18 file and are not modified by this PR. Git diff shows no changes to this file, so these sections are outside the scope of this review. Remove this concern.Likely an incorrect or invalid review comment.
Member
|
Feel free to push these directly into #9067 or add them later when this is merged. |
igorpecovnik
approved these changes
Dec 17, 2025
Contributor
|
✅ This PR has been reviewed and approved — all set for merge! |
igorpecovnik
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds uart1, uart2, and uart3 overlays to enable ttyS1, ttyS2, and ttyS3, respectively.
Documentation summary for feature / change
Append uart? to the overlay= line in armbianEnv.txt to enable the respective UART(s)
How Has This Been Tested?
Tested with GPS module under "current" 6.12 kernel
Please delete options that are not relevant.
Summary by CodeRabbit
Release Notes
New Features
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.