Skip to content

Conversation

@dustinbleile
Copy link
Contributor

Showing changes to allow blank ipr_conn when ipr_upload = False, described in PR comment

#89 (review)

@dustinbleile dustinbleile requested a review from elewis2 December 12, 2025 20:22
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.56%. Comparing base (7df2a3b) to head (9cd51c3).

Files with missing lines Patch % Lines
pori_python/ipr/main.py 52.17% 11 Missing ⚠️
pori_python/graphkb/util.py 25.00% 3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@                           Coverage Diff                           @@
##           feat/DEVSU-2797-remove-gsc-defaults      #90      +/-   ##
=======================================================================
- Coverage                                83.26%   82.56%   -0.71%     
=======================================================================
  Files                                       18       18              
  Lines                                     2444     2460      +16     
=======================================================================
- Hits                                      2035     2031       -4     
- Misses                                     409      429      +20     
Flag Coverage Δ
unittests 82.56% <50.00%> (-0.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dustinbleile dustinbleile requested a review from elewis2 December 16, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants