exclude partial-only matched kbvars from key alts #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| kb_matches: List[Hashabledict], all_variants: Sequence[IprVariant] | ||
| kb_matches: List[Hashabledict], | ||
| all_variants: Sequence[IprVariant], | ||
| included_kb_matches: List[KbVariantMatch], |
Member
There was a problem hiding this comment.
Can we document what included_kb_matches is used for? I fear we'll forget about it after a while
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #92 +/- ##
===========================================
+ Coverage 83.09% 83.31% +0.22%
===========================================
Files 18 18
Lines 2455 2458 +3
===========================================
+ Hits 2040 2048 +8
+ Misses 415 410 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating the list of key alterations, uses the list of kbvariants prepared in the previous step to exclude alterations that won't appear in the kbmatches section (that is, variants that are not part of a complete match to a kbstatement, if allow_partial_matches is False).