Skip to content

Conversation

@pchickey
Copy link
Contributor

Factor out spawn into an unsafe helper spawn_unchecked where block_on can allow a non-static future and output to execute because dataflow ensures the Task does not outlive the future.

Fixes #107

Factor out `spawn` into an unsafe helper `spawn_unchecked` where
`block_on` can allow a non-static future and output to execute because
dataflow ensures the Task does not outlive the future.

Fixes #107
@pchickey
Copy link
Contributor Author

@yoshuawuyts is this API change a breaking one? It permits more programs to typecheck than previously, and shouldn't break any existing ones.

@pchickey pchickey requested a review from yoshuawuyts November 12, 2025 17:58
@pchickey pchickey force-pushed the pch/block_on_without_static branch from 28def15 to 36171c5 Compare November 12, 2025 21:47
@pchickey pchickey force-pushed the pch/block_on_without_static branch from 36171c5 to 49f2f68 Compare November 14, 2025 22:00
Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the 'static bound here is correct and matches other implementations in the ecosystem.

@pchickey
Copy link
Contributor Author

pchickey commented Dec 8, 2025

Just to provide an update here - a transitive dep upgrade crc-fast has revealed a crashing bug in the wasm-ld linker used under the hood. I have reproduced the bug locally with a debug build of llvm/rust to get a better stack trace, but I haven't had time to do anything beyond that, including report a bug upstream, since I haven't made a small enough reproduction.

If necessary we can turn off the wstd-aws CI checks that pull in crc-fast as the transitive dep in order to get CI working again, but that hasn't seemed urgent, so I haven't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'static constraint and borrowed resources

3 participants