Skip to content

Conversation

@hudlow
Copy link
Collaborator

@hudlow hudlow commented Dec 12, 2025

Fixes #113.

@slott56 I'm going to need some help with this — it causes the flow logs test to fail, but I think there's something wrong with the test. Unfortunately, I just don't understand the c7n features well enough to debug it.

@hudlow hudlow requested a review from slott56 December 12, 2025 05:27
@hudlow
Copy link
Collaborator Author

hudlow commented Dec 12, 2025

Need to investigate the lint failure...

@slott56
Copy link
Collaborator

slott56 commented Dec 15, 2025

src/celpy/celtypes.py:446: error: Redundant cast to "Iterable[int]"  [redundant-cast]

I'm unclear why this isn't passing. It looks like a new lint version is being used and it doesn't like this redundant cast.

My suggestion is to fix the failing line:

            return super().__new__(cls, cast(Iterable[int], source))

Remove the cast.

Copy link
Collaborator

@slott56 slott56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good.

There is an essentially unrelated change required by a lint failure.

See the comments on the PR for the change that needs to be folded into this change.

@hudlow hudlow requested a review from slott56 December 22, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent behavior with accessing non-existent field

2 participants