feat: add initial proto API to export logs #121
Closed
+470
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the initial proto API to enable exporting logs from boundary instances for a deployment. The intention is for these proto messages to be sent to the workspace agent over a unix socket, which the agent then forwards to coderd for re-emission to stderr.
zedkipp
force-pushed
the
zedkipp/logs-proto-api
branch
from
ef0444f to
532d43c
Compare
Contributor
Author
|
Closing this. Planning to import agent API into boundary as a starting point so we can re-use the generated proto types. If the agent <-> boundary API needs to evolve, we should consider making that a separate API from AgentAPI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the initial proto API to enable exporting logs from boundary instances for a deployment. The intention is for these proto messages to be sent to the workspace agent over a unix socket, which the agent then forwards to coderd for re-emission to stderr.
RFC: https://www.notion.so/coderhq/Agent-Boundary-Logs-2afd579be59280f29629fc9823ac41ba