🤖 fix: Cmd+Q now properly quits app on macOS #1222
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibetitsmike
force-pushed
the
mike/fix-cmd-q-macos
branch
from
011b6ac to
75731bc
Compare
Adding detailed logging to understand why Cmd+Q closes the window instead of quitting the app on macOS: - Quit menu item click handler - mainWindow 'close' and 'closed' events - app 'before-quit' event with disposal state - app 'window-all-closed' event - Cmd+Q detection in renderer (to see if keypress reaches renderer) Run the app and press Cmd+Q, then check the console output. Fixes #1100
ibetitsmike
force-pushed
the
mike/fix-cmd-q-macos
branch
from
75731bc to
e9a8191
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1100 - Cmd+Q now properly quits the app on macOS instead of closing/hiding the window first.
Problem
Pressing Cmd+Q was behaving like Cmd+W (closing the window first) instead of immediately quitting the app. The app would only quit on a second Cmd+Q press after the window was already closed.
Root Cause
The menu structure had
{ role: "close" }in the Window menu for all platforms. On macOS, this may have caused accelerator registration conflicts where Cmd+Q was triggering the window close action instead of the app quit action.Solution
Updated the menu structure to follow the official Electron documentation pattern:
macOS:
Windows/Linux:
This matches standard macOS application behavior where:
closelives in the File menu (not Window menu)Testing
Generated with
mux• Model:mux-gateway:anthropic/claude-opus-4-5• Thinking:high