Update client.py #32
Open
Update client.py #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add close-all-postions endpoint that was missing.
cjost1988
reviewed
Aug 29, 2025
pybitget/client.py
Outdated
| params["productType"] = productType | ||
| return self._request_with_params(POST, MIX_ORDER_V1_URL + '/close-all-positions', params) | ||
| else: | ||
| logger.error("pls check args") |
There was a problem hiding this comment.
I am not a python expert, but, couldn't you type the parameter productType like:
def mix_cp_close_all_positions(self, productType: str):
And then you don't need this check?
If this does not work, it would be nice if the log message is more verbose:
logger.error("Parameter `productType` is missing")
Anyways, I suggest raising an exception, that can be handled from the outside, if the API can't work without the productType parameter.
mzaeemnasir
commented
Sep 18, 2025
Author
mzaeemnasir
left a comment
mzaeemnasir
left a comment
There was a problem hiding this comment.
Updated mix_cp_close_all_positions function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add close-all-postions endpoint that was missing.
/close-all-positions