Fix: Update NEP interface to match NEP_CPU's update #6804
Merged
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently, the NEP_CPU has relesaed a breaking change related to the `qNEP`, the original API has been changed: 1. reaname the `NEP3` to `NEP` 2. add the `ewald.cpp` and `neighbor.cpp`.
DanielZhao0432
approved these changes
Dec 23, 2025
mohanchen
approved these changes
Dec 25, 2025
Collaborator
mohanchen
left a comment
mohanchen
left a comment
There was a problem hiding this comment.
LGTM, thanks for your help!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, the NEP_CPU has released a breaking change related to the
qNEP, the original API has been changed:NEP3toNEP.ewald.cppandneighbor.cpp.Linked Issue
Fix #6800
What's changed?
NEP3inesolver_nep.hhas been renamed toNEPto match the update.