Lock file I/O in UnpackagedPreferencesImplementation #33182
+28
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hey there @@JonasUJ! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Author
|
@dotnet-policy-service agree |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds thread-safe file I/O locking to the UnpackagedPreferencesImplementation class on Windows to prevent IOException when preferences are accessed from multiple threads concurrently.
Key Changes
- Introduces a static
lockerobject for synchronization - Wraps the
Load()method's file operations in a lock block - Wraps the
Save()method's file operations in a lock block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
UnpackagedPreferencesImplementationon Windows does not lock file I/O. Setting preferences from multiple threads sometimes causes an IOException stating that the file is used by another process. The solution is to put a lock inLoadandSaveI'm going on holiday until mid-Jan and won't respond to comments quickly meanwhile.
Issues Fixed
Fixes #27167