Famedly release/v1.143 #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(better context)
…g#811) Co-authored-by: Eric Eastwood <erice@element.io>
> If the returned error is nil, the [Response](https://pkg.go.dev/net/http#Response) will contain a non-nil Body which the user is expected to close. If the Body is not both read to EOF and closed, the [Client](https://pkg.go.dev/net/http#Client)'s underlying [RoundTripper](https://pkg.go.dev/net/http#RoundTripper) (typically [Transport](https://pkg.go.dev/net/http#Transport)) may not be able to re-use a persistent TCP connection to the server for a subsequent "keep-alive" request. > > *-- https://pkg.go.dev/net/http#Client.Do* But it also may leak resources 🤷 See also: - https://blevesearch.com/news/Deferred-Cleanup,-Checking-Errors,-and-Potential-Problems/ - https://stackoverflow.com/questions/47293975/should-i-error-check-close-on-a-response-body - https://manishrjain.com/must-close-golang-http-response
…atrix-org#813) *Spawning from matrix-org#808 per my suggestion on matrix-org#808 (comment) We have other spots that have flawed membership checks that need to be fixed. For example, when our goal is to wait for the user's membership to be `leave`, we should keep checking until it is `leave`. Currently, there are some spots that wait until *any* membership exists for the user and then asserts `leave` on that which is flawed because that user may have previous membership events that may be picked up first instead of waiting for the `leave`. This PR fixes those flawed checks and aligns our membership checks so we don't cargo cult this bad pattern elsewhere. - Generalize our `client.SyncXXX` helpers to use `syncMembershipIn` utility - More robust - Standardize extra `checks` on event (previously, only available with `client.SyncJoinedTo`) - Introduce `client.SyncBannedFrom` so we can differentiate ban/leave
…ement-changes Delayed event management changes
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating to Synapse v1.143 compliance