Skip to content

vulkan: handle rope with large number of rows #18306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jeffbolznv wants to merge 1 commit into
base: master
Choose a base branch
from
Open

vulkan: handle rope with large number of rows #18306

jeffbolznv wants to merge 1 commit into from
+34 −7

Conversation

@jeffbolznv
Copy link
Collaborator

@jeffbolznv jeffbolznv commented Dec 22, 2025 •
edited
Loading

Fixes #18303.

I see a few other ops failing in test-backend-ops when I force a smaller maxworkgroupcount, I'll deal with these in another change. I made a mistake, I don't see other errors now.

@github-actions github-actions bot added testing Everything test related Vulkan Issues specific to the Vulkan backend ggml changes relating to the ggml tensor library for machine learning labels Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggerganov ggerganov Awaiting requested review from ggerganov ggerganov is a code owner

@0cc4m 0cc4m Awaiting requested review from 0cc4m 0cc4m is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

ggml changes relating to the ggml tensor library for machine learning testing Everything test related Vulkan Issues specific to the Vulkan backend

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

mtmd: assert added in #18180 always trips for large images

1 participant

@jeffbolznv