[SPIR-V] Fix void on extented inst sets #8020
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inline SPIR-V on normal instructions had a condition to avoid emitting a result type on instruction with a void return type. This is because instructions like `OpStore` have a void return type, but in SPIR-V have no result id. OpExtInst when defining void instruction (like debugBreak()) always have a result id, even with a void result type. This commits fixes the condition to reflect this. Fixes microsoft#8012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inline SPIR-V on normal instructions had a condition to avoid emitting a result type on instruction with a void return type. This is because instructions like
OpStorehave a void return type, but in SPIR-V have no result id.OpExtInst when defining void instruction (like debugBreak()) always have a result id, even with a void result type. This commits fixes the condition to reflect this.
Fixes #8012