Add a way to stop the stdioTransport in a graceful way #195
+86
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chr-hertel
reviewed
Dec 24, 2025
| $this->processInput(); | ||
| $this->processFiber(); | ||
| $this->flushOutgoingMessages(); | ||
| if (RunnerState::RUNNING !== $this->runnerControl->getState()) { |
Member
There was a problem hiding this comment.
I wonder if this should even be part of the while expression
Member
|
Is this only a STDIO concern? If so, maybe move it to |
chr-hertel
reviewed
Dec 24, 2025
src/Server/Transport/RunnerState.php
Outdated
Comment on lines
22
to
23
| case STOP_AND_DESTROY_SESSION; | ||
| case STOP; |
Member
There was a problem hiding this comment.
struggling a bit with the naming and if RunnerState::STOP really expresses the purpose - it's restarting/reloading the connection without killing/destroying the session, right?
Contributor
Author
There was a problem hiding this comment.
It is breaking out of the while(true) loop without cleaning up sessions.
It does not restart or reload. (That is handled by other processes)
Contributor
Author
|
Thank you. I've updated the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a way to pragmatically stop the server
Motivation and Context
When the server is running with stdioTransport, there is no way to stop it. With this PR, it allows Symfony to do a "reload" feature. See symfony/ai#1280
I could have added this feature into the stdioTransport class directly, but that is less flexible.
How Has This Been Tested?
Local only
Breaking Changes
Types of changes
Checklist
Additional context