Clear value in new board dialog when a new board was created or the edit canceled #7498
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…action or canceling the edit Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
theoholl
requested review from
elzody,
grnd-alt and
luka-nextcloud
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The value for the text input is now cleared after a new board is created or the editing is canceled. When clicking on the 'Add board' button again, an empty text input field is shown.
Screencast.Fix.mp4
Note: I do not like how the existing code does not check if the
createBoardaction was successful. I think the current code now clears the input whether the network request was OK or not. A board title is not very much information to lose, but nonetheless not great UX.