Cleanup for clippy and add checks to CI #366
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little community service here. When using the cli the other day I noticed some warnings, so I figured I'd just clean those up a bit, starting with a rust-toolchain.toml. This turned out to be more of an effort than I thought, but I figure I'll see it through anyway.
The commit messages should tell most of the story for how we got to all the changes in this PR. Wasn't isn't necessarily captured in those: for some of the manual clippy fixes that weren't exactly trivial, I just suppressed the warnings. I figure they can easily be found and cleaned up later if desired, but they don't need to be in this PR.