Team 13 #10

schwartzadev · 2018-03-23T01:50:47Z

this will hold our submissions for the code jam - thanks for setting this up!

update to most recent

gdude2002 · 2018-03-23T09:45:35Z

bot/cogs/snakes.py

+
    @command()
-    async def get(self, ctx: Context, name: str = None):
+    async def get(self, ctx: Context, name: str = "python"):


No, this should default to None. The task requires a random snake if the parameter is left out.

yep - just noticed this - thanks!

lemonsaurus

Keep up the good work!

lemonsaurus · 2018-03-24T01:19:16Z

bot/cogs/snakes.py

        :param name: Optional, the name of the snake to get information for - omit for a random snake
        """
+        embed = discord.Embed(color=0x3E885B)
+        if name == "python":


This should be case insensitive.

Thanks - so when I change line 73 to if name.lower() == "python":, I get an error about comparing NoneTypes since the default name is None (see the method declaration). How should I get around this? Should I do an "if None" check before the python special case or should I do something else?

(discord.ext.commands.errors.CommandInvokeError: Command raised an exception: AttributeError: 'NoneType' object has no attribute 'lower' is the error for reference)

if name and name.lower() == "python":

would work for me.

yep - looks good, thanks

lemonsaurus · 2018-03-24T01:22:06Z

bot/cogs/snakes.py

+        :return: the full JSON from the search API
+        """
+        url = "https://api.unsplash.com/search/photos?client_id" \
+              "={0}&query={1}+snake".format(os.environ.get("UNSPLASH_CLIENT_ID"), snake_name)


this string is a bit messy. prefer implicit string joins inside paranthesis and f-strings to \ line continuation and formats.

client_id = os.environ.get("UNSPLASH_CLIENT_ID") url = ( "https://api.unsplash.com/search/photos?client_id" f"={client_id}&query={snake_name}+snake" )

lemonsaurus · 2018-03-24T01:22:59Z

bot/cogs/snakes.py

        :return: A dict containing information on a snake
        """

+    async def get_snek_qwant_json(self, snake_name):


snake_name should be type hinted, as should the return type.

lemonsaurus · 2018-03-24T01:23:58Z

bot/cogs/snakes.py

+                response = await response.read()
+                return json.loads(response.decode("utf-8"))
+
+    async def get_snek_image(self, name):


name should be type hinted, as should return type.

lemonsaurus · 2018-03-24T01:28:07Z

bot/cogs/snakes.py

+            embed.add_field(
+                name="Python (programming language)",
+                value="*Guido van Rossum*\n\n"
+                      "This language is neither dangerous nor venomous and be found in software globally",


Unless you're a pirate, this should be "and can be found".

lemonsaurus · 2018-03-24T01:29:44Z

bot/cogs/snakes.py

+            # handle Python special case
+            embed.add_field(
+                name="Python (programming language)",
+                value="*Guido van Rossum*\n\n"


multiline implicit string joins should be wrapped inside paranthesis, so that it's clear that they're one thing. This is a bit too implicit.

Can you explain this? I'm not super clear as to what you mean...

value=( "*Guido van Rossum*\n\n" "This language is neither dangerous nor venomous and be found in software globally" ),

this is one way.

or if you prefer it, this is acceptable too

value=("*Guido van Rossum*\n\n" "This language is neither dangerous nor venomous and be found in software globally"),

…1mn

…1mn)

…sponse, just return the embed

[UPDATE] Ignored a silly rule from flake8.

Adding W503 and E226 to flake8 ignore list.

…l_snakes_url var

… results

…ers of results

Use Qwant images instead of Unsplash

gdude2002

I wonder why prith didn't push anything except for one commit

gdude2002 · 2018-03-25T10:45:38Z

Pipfile

@@ -1,15 +1,21 @@
 [[source]]
+


There's loads of extra spaces in this file now. Did you edit it by hand?

nope - this happened automatically when I installed the titlecase package

gdude2002 · 2018-03-25T10:47:21Z

Pipfile.lock

-            "sha256": "d797e580ddcddc99bf058109ab0306ad584c2902752a3d4076ba713fdc580fb7"
+            "sha256": "2cca231e2bd4b5fdaa06fd33b68143231524f2855847ebf4cc497462e135fdf2"
+        },
+        "host-environment-markers": {


Huh. Where'd this come from? Also, why did you sort all the hashes in this file?

this happened automatically when I installed the titlecase package

gdude2002 · 2018-03-25T10:47:40Z

bot/cogs/resources/facts.json

+    "Snakes kill over 40,000 people a year—though, with unreported incidents, the total may be over 100,000. About half of these deaths are in India.",
+    "Some members of the U.S. Army Special Forces are taught to kill and eat snakes during their survival training, which has earned them the nickname “Snake Eaters.”"
+  ]
+}


Missing a newline at the end of the file.

gdude2002 · 2018-03-25T10:49:31Z

bot/cogs/snakes.py

+        async with aiohttp.ClientSession() as session:
+            async with session.get(url, headers=head) as response:
+                response = await response.read()
+                return json.loads(response.decode("utf-8"))


Couldn't you just use return await response.json()?

gdude2002 · 2018-03-25T10:55:39Z

bot/cogs/snakes.py

        :param name: Optional, the name of the snake to get information for - omit for a random snake
        :return: A dict containing information on a snake
        """
+        base_url = "https://protected-reef-75100.herokuapp.com/"


Huh, that's an odd decision.

Can we get more info on what you're doing here?

Hey @gdude2002 , that's where we hosted our snake API. Here's the link to the repo. This is where most of my commits are :)

gdude2002 · 2018-03-25T10:58:51Z

bot/cogs/snakes.py

    # Any additional commands can be placed here. Be creative, but keep it to a reasonable amount!

+    @command(aliases=["f"])
+    async def fact(self, ctx: Context):


I would just like to point out that you put a ton of work into the get command, and not much into your extra stuff.

The marking is heavily weighted towards the extra creative stuff. But you still have 12 hours!

…photos per snake

Add video command

Add cat input for GIF

gdude2002 · 2018-03-25T21:52:32Z

You code is failing to lint. Please see Travis for more information.

…ev/code-jam-1

Add Zen of Python

schwartzadev added 4 commits March 22, 2018 19:45

Merge pull request #1 from discord-python/master

0aa95cb

update to most recent

add preliminary snake 'get' command

c2505ce

allow user input for snake names

8c25449

change imports order, index format string

e3f0c70

gdude2002 reviewed Mar 23, 2018

View reviewed changes

schwartzadev added 2 commits March 23, 2018 15:53

add interim fancy message formatting, handle special python case

611501f

add snake to query string for images

85bb282

lemonsaurus reviewed Mar 24, 2018

View reviewed changes

schwartzadev and others added 22 commits March 23, 2018 20:10

add list of snake facts, sources files

243b51f

update sources

b4e6468

add snake fact command

cea4cf3

clean up code - type hinting, spelling, URL formatting, etc. (thanks @…

3a37252

…1mn)

fix broken URL

6602d02

resolve PEP E226

62401e5

implement more of @1mn's suggestions

7f63f4f

use the snake emoji

0137051

integrate with the API - thanks @prithajnath - remove message from re…

1e710db

…sponse, just return the embed

Merge pull request #2 from discord-python/master

5844b02

[UPDATE] Ignored a silly rule from flake8.

Add search endpoint and auth headers

3656c01

Merge pull request #3 from discord-python/master

48f8de4

Adding W503 and E226 to flake8 ignore list.

remove repetitive embed code, fix linting errors (hopefully!)

bf2f9ea

resolve flake8 - P103

d8a26ba

resolve linting issues

9c8a9f4

implement random api endpoint

697f557

implement titlecase for common and scientific names, remove unused al…

0951f92

…l_snakes_url var

return number of matches in searches, add handling of searches with 0…

544bed5

… results

add qwant api in favor of unsplash, including handling for small numb…

a2255e7

…ers of results

rm prints

9b2f8d0

Merge pull request #4 from schwartzadev/qwant-images

f30abab

Use Qwant images instead of Unsplash

add newline between imports (I201) for linting

48f2584

gdude2002 suggested changes Mar 25, 2018

View reviewed changes

prithajnath and others added 18 commits March 25, 2018 08:02

Add APIs used

e5901b6

Add some GIFs for facts

5770c79

linting updates

259c5a6

add list of zen python sayings

2d45b2f

use response.json() for qwant access

6776264

handle snakes without a location, reduce variance in photos to three …

03f9b61

…photos per snake

Add cat input for GIF

a27582a

start video command - needs formatting work for embed

e2d556b

remove embed (Discord is finnicky), fix command format

003ace9

update docstring for get

2366c43

update video docstring

ea31798

fix get_video_json docstring

a9f8863

Add Zen of Python

01c701b

Merge pull request #6 from schwartzadev/video-command

9d28fa3

Add video command

Merge branch 'master' into prithaj_gif_categories

c98bc6e

Merge pull request #5 from schwartzadev/prithaj_gif_categories

d2482b2

Add cat input for GIF

Add alias for this

f1b7a2c

Add descp for zen

ff361b8

schwartzadev added 8 commits March 25, 2018 16:02

Merge branch 'prithaj_zen_of_python' of https://github.com/schwartzad…

13937c1

…ev/code-jam-1

lint, fix spelling

3279319

lint, fix spelling

e0d2bf2

Merge pull request #7 from schwartzadev/prithaj_zen_of_python

361cc45

Add Zen of Python

Merge branch 'master' of https://github.com/schwartzadev/code-jam-1

ac33379

fix arguments, lint, and format for get_snek_fact

375f4bc

linting

71a0f44

add information about credentials

99f00f2

Uh oh!

Team 13 #10

Are you sure you want to change the base?

Team 13 #10

Uh oh!

Conversation

schwartzadev commented Mar 23, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lemonsaurus left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gdude2002 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gdude2002 commented Mar 25, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants