-
-
Notifications
You must be signed in to change notification settings - Fork 946
Replace deprecated workflow with RtD app #1713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@hugovk done |
StanFromIreland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks! I opened #1714 to test, but it doesn't seem to have triggered. At least I can see it's installed on this repo:
Will check tomorrow. |
|
Right, figured it out on my fork: hugovk#37 @Mariatta Please could you add Then I can complete the migration to the app and then check "Show build overview in a comment" at https://app.readthedocs.org/dashboard/cpython-devguide/pull-requests/ |
|
@brettcannon Or please could you do the above to add me? #1713 (comment) |
Invite sent! |
|
Thanks, accepted! I don't see the migration option for this repo, I think it needs someone with admin access to the repo as well. I've added @JacobCoffee to RtD and will talk with him to get it set up. |

For python/core-workflow#587.
This workflow is deprecated, and uses the
pull_request_targettarget which can be insecure.Let's test replacing it with the Read the Docs app. If it goes well, we can replace it in the other repos.
@python/organization-owners I've sent a request to install the RtD app for just this repo, please could you enable it?
📚 Documentation preview 📚: https://cpython-devguide--1713.org.readthedocs.build/