Improve sqlite Aggregration Protocols
#15188
Draft
+172
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
max-muoto
force-pushed
the
fix-aggregration-protocols
branch
from
6f5bc08 to
ef3dc7d
Compare
max-muoto
commented
Dec 30, 2025
| # And for num_params = -1, which means the aggregate must accept any number of parameters. | ||
| @overload | ||
| def create_window_function( | ||
| self, name: str, num_params: Literal[-1], aggregate_class: Callable[[], _AnyParamWindowAggregateClass] | None, / |
Contributor
Author
There was a problem hiding this comment.
We shouldn't necessarily enforce usage of *args in the any params case.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
max-muoto
force-pushed
the
fix-aggregration-protocols
branch
from
199a193 to
8adf710
Compare
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #12141 and improves the typing for
create_aggregateby:n_arg=1case that the protocol only accepts a single argument forstepandinverse, and a separate protocol accepting N arguments when given a positive integer value or -1. Properties withCallable[..., object]are used in order to allow the implementer to accept any number of named positional or key-word arguments._SingleParamWindowAggregateClassand_AnyParamWindowAggregateClass).This is primarily a re-open of #12192 addressing the issues called out in https://github.com/python/typeshed/pull/12192/changes#r1651411242. Looking back on this PR, the return-types were too strict as well, there's not necessarily a strict requirement that the return types match the input types so we avoid using generics for returns as well now.