Skip to content

Improve type annotations for ttk.Widget #15189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DanielOnGitHub17 wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Improve type annotations for ttk.Widget #15189

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d3501e1
Improve type annotations for ttk.Widget
DanielOnGitHub17 Dec 29, 2025
4edf5a6
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 29, 2025
8c412e4
Improve type annotations for Widget.instate to better represent imple…
DanielOnGitHub17 Dec 29, 2025
51b54ae
Fix: ParamSpec import
DanielOnGitHub17 Dec 29, 2025
c825604
Fix: Make ParamSpec and TypeVar private
DanielOnGitHub17 Dec 29, 2025
73e6b1f
Fix: Fallback for Python3.9 -> importing ParamSpec from typing_extens…
DanielOnGitHub17 Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions stdlib/tkinter/ttk.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@ import _tkinter
import sys
import tkinter
from _typeshed import MaybeNone
from collections.abc import Callable, Iterable
from collections.abc import Callable, Iterable, Sequence
from tkinter.font import _FontDescription
from typing import Any, Literal, TypedDict, overload, type_check_only
from typing_extensions import Never, TypeAlias, Unpack
from typing import Any, Literal, TypedDict, TypeVar, overload, type_check_only
from typing_extensions import Never, ParamSpec, TypeAlias, Unpack

__all__ = [
"Button",
Expand Down Expand Up @@ -54,6 +54,9 @@ _Statespec: TypeAlias = tuple[Unpack[tuple[str, ...]], Any]
_ImageStatespec: TypeAlias = tuple[Unpack[tuple[str, ...]], tkinter._Image | str]
_VsapiStatespec: TypeAlias = tuple[Unpack[tuple[str, ...]], int]

_P = ParamSpec("_P")
_T = TypeVar("_T")

class _Layout(TypedDict, total=False):
side: Literal["left", "right", "top", "bottom"]
sticky: str # consists of letters 'n', 's', 'w', 'e', may contain repeats, may be empty
Expand Down Expand Up @@ -201,10 +204,13 @@ class Style:
def theme_use(self, themename: None = None) -> str: ...

class Widget(tkinter.Widget):
def __init__(self, master: tkinter.Misc | None, widgetname, kw=None) -> None: ...
def __init__(self, master: tkinter.Misc | None, widgetname: str | None, kw: dict[str, Any] | None = None) -> None: ...
def identify(self, x: int, y: int) -> str: ...
def instate(self, statespec, callback=None, *args, **kw): ...
def state(self, statespec=None): ...
@overload
def instate(self, statespec: Sequence[str], callback: None = None) -> bool: ...
@overload
def instate(self, statespec: Sequence[str], callback: Callable[_P, _T], *args: _P.args, **kw: _P.kwargs) -> bool | _T: ...
def state(self, statespec: Sequence[str] | None = None) -> tuple[str, ...]: ...

class Button(Widget):
def __init__(
Expand Down