[DeadCode] Add RemoveDeadIfBlocksRector

rules-tests/DeadCode/Rector/If_/RemoveDeadIfBlockRector/Fixture/fixture.php.inc

@@ -0,0 +1,52 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\If_\RemoveDeadIfBlockRector\Fixture;
+
+class RemoveDeadIfBlock
+{
+    public function run($condition)
+    {
+        if ($value) {
+        } elseif ($differentValue) {
+        } else {
+        }
+
+        if ($differentValue) {
+            echo 'different';
+        } elseif ($value) {
+        } else {
+        }
+
+        if ($differentValue) {
+        } elseif ($value) {
+            echo 'value';
+        } else {
+        }
+
+        return $differentValue;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\If_\RemoveDeadIfBlockRector\Fixture;
+
+class RemoveDeadIfBlock
+{
+    public function run($condition)
+    {
+        if ($differentValue) {
+            echo 'different';
+        }
+
+        if (!$differentValue && $value) {
+            echo 'value';
+        }
+
+        return $differentValue;
+    }
+}
+
+?>

rules-tests/DeadCode/Rector/If_/RemoveDeadIfBlockRector/Fixture/if_else_no_stmt.php.inc

@@ -0,0 +1,32 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\If_\RemoveDeadIfBlockRector\Fixture;
+
+class IfElseNoStmt
+{
+    public function run($condition)
+    {
+        if ($condition) {
+            echo "something";
+        } else {
+        }
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\If_\RemoveDeadIfBlockRector\Fixture;
+
+class IfElseNoStmt
+{
+    public function run($condition)
+    {
+        if ($condition) {
+            echo "something";
+        }
+    }
+}
+
+?>

rules-tests/DeadCode/Rector/If_/RemoveDeadIfBlockRector/Fixture/if_elseif_no_stmt.php.inc

@@ -0,0 +1,36 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\If_\RemoveDeadIfBlockRector\Fixture;
+
+class IfElseNoStmt
+{
+    public function run($condition)
+    {
+        if ($condition) {
+            echo "something";
+        } elseif (!$condition) {
+        } elseif (true) {
+            echo "global";
+        }
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\If_\RemoveDeadIfBlockRector\Fixture;
+
+class IfElseNoStmt
+{
+    public function run($condition)
+    {
+        if ($condition) {
+            echo "something";
+        } elseif (true) {
+            echo "global";
+        }
+    }
+}
+
+?>

rules-tests/DeadCode/Rector/If_/RemoveDeadIfBlockRector/Fixture/if_no_stmt_with_else.php.inc

@@ -0,0 +1,32 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\If_\RemoveDeadIfBlockRector\Fixture;
+
+class IfNoStmtWithElse
+{
+    public function run($condition)
+    {
+        if ($condition) {
+        } else {
+            echo "something";
+        }
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\If_\RemoveDeadIfBlockRector\Fixture;
+
+class IfNoStmtWithElse
+{
+    public function run($condition)
+    {
+        if (!$condition) {
+            echo "something";
+        }
+    }
+}
+
+?>

rules-tests/DeadCode/Rector/If_/RemoveDeadIfBlockRector/Fixture/if_no_stmt_with_else_no_stmt.php.inc

@@ -0,0 +1,28 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\If_\RemoveDeadIfBlockRector\Fixture;
+
+class IfNoStmtWithElseNoStmt
+{
+    public function run($condition)
+    {
+        if ($condition) {
+        } else {
+        }
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\If_\RemoveDeadIfBlockRector\Fixture;
+
+class IfNoStmtWithElseNoStmt
+{
+    public function run($condition)
+    {
+    }
+}
+
+?>

rules-tests/DeadCode/Rector/If_/RemoveDeadIfBlockRector/Fixture/side_effect_checks.php.inc

@@ -0,0 +1,45 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\If_\RemoveDeadIfBlockRector\Fixture;
+
+class SideEffectChecks
+{
+    public function run()
+    {
+        if (10) {
+        }
+
+        if (true) {
+        }
+
+        if (5 + 10) {
+        }
+
+        if ($this->someCall()) {
+        }
+
+        if (false) {
+        } elseif ($this->anotherCall()) {
+        }
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\If_\RemoveDeadIfBlockRector\Fixture;
+
+class SideEffectChecks
+{
+    public function run()
+    {
+        if ($this->someCall()) {
+        }
+
+        if (!false && $this->anotherCall()) {
+        }
+    }
+}
+
+?>

rules-tests/DeadCode/Rector/If_/RemoveDeadIfBlockRector/Fixture/skip_if_comment.php.inc

@@ -0,0 +1,19 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\If_\RemoveDeadIfBlockRector\Fixture;
+
+class MergeComments
+{
+    public function run($b)
+    {
+        // toplevel
+        if ($b) {
+        } elseif (!$b) {
+            // first inner
+            f();
+            // second inner
+        }
+    }
+}
+
+?>

rules-tests/DeadCode/Rector/If_/RemoveDeadIfBlockRector/Fixture/skip_property_fetch.php.inc

@@ -0,0 +1,17 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\If_\RemoveDeadIfBlockRector\Fixture;
+
+class SkipPropertyFetch
+{
+    public function run($obj, $condition)
+    {
+        if ($condition) {
+            echo '1';
+        } elseif ($obj->v) {
+            echo '2';
+        }
+    }
+}
+
+?>

rules-tests/DeadCode/Rector/If_/RemoveDeadIfBlockRector/Fixture/skip_used_in_next_stmt.php.inc

@@ -0,0 +1,19 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\If_\RemoveDeadIfBlockRector\Fixture;
+
+class SkipUsedInNextStmt
+{
+    public function run($resultLen, $result, $decimalSep)
+    {
+        for ($i = $resultLen - 1; $i >= 0 && $result[$i] === '0'; $i--) {
+            ;
+        }
+
+        if ($i >= 0 && $result[$i] === $decimalSep) {
+          $i--;
+        }
+
+        $result = substr($result, 0, $i + 1);
+    }
+}

rules-tests/DeadCode/Rector/If_/RemoveDeadIfBlockRector/Fixture/skip_used_in_next_stmt2.php.inc

@@ -0,0 +1,19 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\If_\RemoveDeadIfBlockRector\Fixture;
+
+class SkipUsedInNextStmt2
+{
+    public function run($resultLen, $result, $decimalSep)
+    {
+        foreach ($result as $i => $value) {
+            ;
+        }
+
+        if ($i >= 0 && $result[$i] === $decimalSep) {
+          $i--;
+        }
+
+        $result = substr($result, 0, $i + 1);
+    }
+}

rules-tests/DeadCode/Rector/If_/RemoveDeadIfBlockRector/RemoveDeadIfBlockRectorTest.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\DeadCode\Rector\If_\RemoveDeadIfBlockRector;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class RemoveDeadIfBlockRectorTest extends AbstractRectorTestCase
+{
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}

rules-tests/DeadCode/Rector/If_/RemoveDeadIfBlockRector/config/configured_rule.php

@@ -0,0 +1,9 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\DeadCode\Rector\If_\RemoveDeadIfBlockRector;
+
+return RectorConfig::configure()
+    ->withRules([RemoveDeadIfBlockRector::class]);