Manage named arguments when replacing a value #7784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlos-granados
commented
Dec 30, 2025
| return $this->processParams($node, $replaceArgumentDefaultValue); | ||
| } | ||
|
|
||
| if (! isset($node->args[$replaceArgumentDefaultValue->getPosition()])) { |
Contributor
Author
There was a problem hiding this comment.
We need to do this check later because the position may change if we have named arguments
carlos-granados
commented
Dec 30, 2025
| $replaceArgumentDefaultValue->getValueBefore() | ||
| ) && $argValue === $replaceArgumentDefaultValue->getValueBefore()) { | ||
| $expr->args[$position] = $this->normalizeValueToArgument($replaceArgumentDefaultValue->getValueAfter()); | ||
| $particularArg->value = $this->normalizeValue($replaceArgumentDefaultValue->getValueAfter()); |
Contributor
Author
There was a problem hiding this comment.
We don't want to create a new argument, instead we just set the value of the existing argument. This allows us to keep named arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the ArgumentDefaultValueReplacer class (which is used by the ReplaceArgumentDefaultValueRector and FunctionArgumentDefaultValueReplacerRector rules) to handle named arguments