Skip to content

chore: unify event emitter #8577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
AdityaHegde wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: unify event emitter #8577

AdityaHegde wants to merge 2 commits into from
+160 −222

Conversation

@AdityaHegde
Copy link
Collaborator

@AdityaHegde AdityaHegde commented Dec 30, 2025 •
edited
Loading

We have 3 different classes that reimplement event emitter code. We also have the conversation class that uses the callback method for event handling. This PR unifies them by adding an EventEmitter class.

Used in #8505 to have a separate "listener" to chat conversation messages.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@AdityaHegde AdityaHegde force-pushed the chore/unify-event-emitter branch from 4e0d57e to 6ccc6d4 Compare December 30, 2025 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericpgreen2 ericpgreen2 Awaiting requested review from ericpgreen2

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AdityaHegde