-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
Enable file locking support for Hurd #150058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
like Illumos (rust-lang#148322) and aix (rust-lang#148619), Hurd was missed when originally introducing locking gates per target OS in rust-lang#132977. building rustc on Hurd was broken as a result since 1.91. Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
|
(marked as draft for now because my test build of 1.91.1 with this backported is still running, and I want to ensure it works as expected end-to-end before it gets merged!) |
|
Thanks for the fix. This obviously seems fine if it fixes the issue, which you will know better, so, r=me after you verify. r? @workingjubilee |
|
✌️ @Fabian-Gruenbichler, you can now approve this pull request! If @workingjubilee told you to " |
|
|
bors r=@workingjubilee |
|
can confirm that building 1.91.1 with a backport of this and |
like Illumos and AIX, Hurd was missed when originally introducing locking gates per target OS. building rustc on Hurd was broken as a result since 1.91.