Skip to content

Partially revert #147888 and print warning if LLVM CMake dir is missing when building Enzyme #150070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 2 commits into from
Dec 17, 2025
Merged

Partially revert #147888 and print warning if LLVM CMake dir is missing when building Enzyme #150070

bors merged 2 commits into from
Dec 17, 2025
+12 −6

Conversation

@Kobzol
Copy link
Member

@Kobzol Kobzol commented Dec 16, 2025

Partially reverts #147888, Enzyme cannot be build with download-ci-llvm = true.

r? @ZuseZ4

@rustbot
Copy link
Collaborator

rustbot commented Dec 16, 2025

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Dec 16, 2025
@rustbot

This comment has been minimized.

Sign in to view
ZuseZ4
ZuseZ4 reviewed Dec 16, 2025
View reviewed changes
@ZuseZ4
Copy link
Member

ZuseZ4 commented Dec 16, 2025

I updated the change_tracker when enabling it, so you should probably leave an update now that we disable it.
Also rustbot doesn't seem to like your commit msg, not sure if you want to fix that.
Otherwise lgtm.

@Kobzol
Copy link
Member Author

Kobzol commented Dec 16, 2025

I updated the change_tracker when enabling it, so you should probably leave an update now that we disable it.

I think that would be just unnecessary churn, people sometimes complain that we put too many changes there and then they ignore the report completely. I'd just put a note to the description of the previous PR that it was reverted.

This was referenced Dec 16, 2025
Merged
Draft
@ZuseZ4
Copy link
Member

ZuseZ4 commented Dec 16, 2025

good to know, then r=me once ci is green.

@Kobzol
Copy link
Member Author

Kobzol commented Dec 16, 2025

@bors r=ZuseZ4

@bors
Copy link
Collaborator

bors commented Dec 16, 2025

📌 Commit 7463b15 has been approved by ZuseZ4

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 16, 2025
jhpratt added a commit to jhpratt/rust that referenced this pull request Dec 17, 2025
@jhpratt
Rollup merge of rust-lang#150070 - Kobzol:enzyme-error, r=ZuseZ4
e4530a8 
Partially revert rust-lang#147888 and print warning if LLVM CMake dir is missing when building Enzyme

Partially reverts rust-lang#147888, Enzyme cannot be build with `download-ci-llvm = true`.

r? `@ZuseZ4`
@jhpratt jhpratt mentioned this pull request Dec 17, 2025
Merged
bors added a commit that referenced this pull request Dec 17, 2025
@bors
Auto merge of #150079 - jhpratt:rollup-iehzejf, r=jhpratt
ec6f622 
Rollup of 4 pull requests

Successful merges:

 - #150000 (Port `#[rustc_legacy_const_generics]` to use attribute parser )
 - #150060 (autodiff: emit an error if we fail to find libEnzyme)
 - #150070 (Partially revert #147888 and print warning if LLVM CMake dir is missing when building Enzyme)
 - #150072 (Port #[no_link] to use attribute parser)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1a7df03 into rust-lang:main Dec 17, 2025
11 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Dec 17, 2025
rust-timer added a commit that referenced this pull request Dec 17, 2025
@rust-timer
Unrolled build for #150070
71bd139 
Rollup merge of #150070 - Kobzol:enzyme-error, r=ZuseZ4

Partially revert #147888 and print warning if LLVM CMake dir is missing when building Enzyme

Partially reverts #147888, Enzyme cannot be build with `download-ci-llvm = true`.

r? ``@ZuseZ4``
@Kobzol Kobzol deleted the enzyme-error branch December 17, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZuseZ4 ZuseZ4 ZuseZ4 left review comments

Assignees

@ZuseZ4 ZuseZ4

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Kobzol @rustbot @ZuseZ4 @bors