Skip to content

chore: update shelljs and drop old node support #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nfischer merged 1 commit into from
Mar 9, 2025
Merged

chore: update shelljs and drop old node support #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,9 @@ jobs:
fail-fast: false
matrix:
node-version:
- 6
- 8
- 10
- 12
- 14
- 16
- 18
- 20
- 22
os:
- ubuntu-latest
- macos-latest
Expand All @@ -27,4 +23,4 @@ jobs:
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm run test
- run: npm test
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,18 +31,18 @@
"eslint-config-airbnb-base": "^13.1.0",
"eslint-plugin-import": "^2.17.3",
"mocha": "^5.2.0",
"shelljs": "^0.8.5",
"shelljs": "^0.9.1",
"shelljs-changelog": "^0.2.6",
"shelljs-release": "^0.5.1",
"should": "^13.2.3"
},
"peerDependencies": {
"shelljs": "^0.8.5"
"shelljs": "^0.9.1"
},
"dependencies": {
"opener": "^1.4.1"
},
"engines": {
"node": ">=6"
"node": ">=18"
}
}
2 changes: 1 addition & 1 deletion test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ describe('plugin-open', function () {
* Plugins can easily take advantage of ShellJS's built-in glob expansion.
* This is indicated by the globStart option
*/
var ret = shell.open('te?t/*st.js');
var ret = shell.open('te*/t?st.js');
ret.code.should.equal(0);
ret.stdout.should.equal('');
assert.ok(!ret.stderr);
Expand Down