feat(website): add terraphim.ai website migration

[AlexMikhalev]

Summary

• Migrate terraphim.ai website to Zola static site generator with DeepThought theme
• Add production Svelte frontend build assets to server dist
• Document macOS release pipeline and Homebrew publication patterns in lessons-learned

Changes

• Website: Complete Zola-based website with config, templates, content, and static assets
• Frontend: Updated dist/index.html with production build (JS bundles, CSS, icons)
• Documentation: Added patterns for disciplined development, GitHub PATs, native architecture builds, Homebrew taps, and 1Password CI integration
• CI: Minor release workflow adjustments

Test plan

• Verify website builds with cd website && zola build
• Verify server compiles with embedded frontend: cargo build -p terraphim_server
• Check website renders correctly locally: cd website && zola serve

🤖 Generated with Claude Code

[claude]

Code Review - PR #378: Website Migration

Summary

This PR successfully migrates the terraphim.ai website to Zola static site generator and updates the frontend build assets. Overall, this is a solid migration with good documentation. I've identified several areas for improvement below.

---

✅ Positive Aspects

1. Good Documentation: WEBSITE_MIGRATION_COMPLETE.md provides excellent migration context
2. Code Quality Improvements:
   • Rust code cleanup in terraphim_ai_nodejs/src/lib.rs removes unnecessary variable binding
   • Comment formatting improvements follow Rust conventions
3. Security Headers: Website config includes good security practices:
   • external_links_target_blank = true with rel="noopener"
   • external_links_no_follow = true
   • external_links_no_referrer = true
4. Proper Gitignore: Excludes build artifacts (website/public/, videos, backgrounds)

---

⚠️ Issues and Recommendations

1. Git Submodule Duplication (High Priority)

Issue: Two identical .gitmodules files exist:

• Root: .gitmodules
• Website: website/.gitmodules

Both point to the same DeepThought theme submodule.

Recommendation:

• Remove one of these files (likely website/.gitmodules)
• Git submodules should be defined once at the repository root
• Verify submodule initialization works correctly after cleanup

# Verify current submodule status
git submodule status
# Remove duplicate if confirmed
git rm website/.gitmodules

---

2. Test Settings Reordering (Low Priority)

Issue: crates/terraphim_settings/test_settings/settings.toml has sections reordered without functional changes.

Observation:

• Only formatting/ordering changed (s3 moved to top, field order within profiles changed)
• No security concern as these are test credentials (test_secret, test_key)
• Adds noise to the PR diff

Recommendation:

• Consider reverting this file if the reordering wasn't intentional
• If it was intentional (e.g., alphabetical ordering), document why in commit message

---

3. Frontend Build Assets (Medium Priority)

Issue: terraphim_server/dist/index.html includes production build with versioned assets.

Concerns:

• Asset paths use content hashing (index-C3WAByOS.js, vendor-ui-BYJxBUEn.js)
• No verification that these files exist in the dist/ directory
• PR doesn't show the actual JS/CSS files being added

Recommendations:

1. Verify all referenced assets exist:

   ls -la terraphim_server/dist/assets/

2. Consider documenting the frontend build process in the PR description
3. Add a build verification step to CI

---

4. Missing Build Verification (Medium Priority)

Issue: PR checklist shows unverified items:

• Verify website builds with cd website && zola build
• Verify server compiles with embedded frontend: cargo build -p terraphim_server
• Check website renders correctly locally: cd website && zola serve

Recommendation:
Execute these verification steps before merging:

# Test website build
cd website && zola build

# Test server compilation with embedded frontend
cargo build -p terraphim_server

# Test local rendering
cd website && zola serve

According to CLAUDE.md guidelines: "Check that everything is working - ci, tests, build, release, tauri, run pre-commit checks and then commit."

---

5. Newline Missing in .gitmodules (Low Priority)

Issue: website/.gitmodules missing final newline.

Recommendation:

echo >> website/.gitmodules  # If keeping this file

Per POSIX standards, text files should end with a newline character.

---

6. Security Considerations (Info)

External Services Configured:

• Google Analytics: G-5KRW51RLEJ
• Disqus comments: terraphim-ai
• Public email addresses exposed in config

Observations:

• These are appropriate for a public-facing website
• Email addresses are already public (team contacts)
• Test credentials in settings.toml are clearly marked as test values

No security concerns identified ✓

---

7. Performance Consideration

Issue: minify_html = false in website config.

Recommendation:
Consider enabling HTML minification for production builds:

minify_html = true

This reduces bandwidth and improves page load times.

---

📋 Test Coverage

Rust Changes:

• ✅ Minimal functional changes (code cleanup only)
• ✅ Comment notes that tests exist in Node.js integration tests
• ⚠️ No new tests required, but should verify existing tests still pass

Website:

• ⚠️ No automated tests for Zola build (expected for static sites)
• ⚠️ Manual verification required per test plan

---

🎯 Recommendations Summary

Before Merging:

1. ✅ Remove duplicate .gitmodules file
2. ✅ Complete the test plan checklist items
3. ✅ Verify frontend assets exist in dist/
4. ✅ Run pre-commit hooks per CLAUDE.md

Optional Improvements:

1. Consider enabling HTML minification
2. Document frontend build process
3. Revert test_settings.toml if reordering was unintentional

---

📝 Conventional Commit Compliance

Commit messages follow conventional commit format:

• feat(website): add terraphim.ai website migration ✓
• feat(website): add frontend build and documentation updates ✓

Per CLAUDE.md: Use Conventional Commit prefixes (fix:, feat:, refactor:)

---

Final Verdict

Status: ✅ Approve with requested changes

This is a well-documented migration with good practices. Address the duplicate .gitmodules file and complete the test plan verification before merging. The code quality improvements are good, and no security issues were identified.

Estimated Risk: Low - primarily static content and build configuration