fix: auto-shift model coordinates to stay within Minecraft bounds (-16 to 32) #233
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When BetterModel exports models to Minecraft JSON format, element coordinates can exceed Minecraft's hard bounds (-16 to 32), causing errors like:
This happens when the original bbmodel has coordinates slightly outside bounds, or when the split/export process applies offsets that push coordinates out of range.
Solution
This PR adds automatic bounds validation and coordinate shifting:
from,to, and rotationoriginto keep model parts alignedExample
A model part with Z range
-20to+9:minZ = -20is below-16offsetZ = +4-16to+13(within bounds)Changes
MIN_BOUNDandMAX_BOUNDconstantscalculateFrom()andcalculateTo()helper methodscalculateBoundsOffset()to compute required shiftGroup.buildJson()to pre-calculate bounds and offsetCube.buildJson()to accept and apply the offsetTesting