Skip to content

Conversation

@robertosfield
Copy link
Collaborator

No description provided.

@robertosfield robertosfield merged commit 7582505 into master Dec 23, 2025
16 checks passed
@AnyOldName3
Copy link
Contributor

This might cause problems on distros that provide glslang 13 or older, as it'll be picked up by find_package, and then fail to build. Hopefully, it's old enough that no one's using it anymore.

@robertosfield
Copy link
Collaborator Author

I have 13.x by from source and didn't see any build problems, with the VSG disabling shader compile support and reporting warning. Not sure yet why the find_package failed as glslang-config.cmake was installed when I installed the compiled glslang library.

This is what I see with VSG master with a fresh cmake

--- sh
$ cmake . -DCMAKE_INSTALL_PREFIX=~/install

-- The CXX compiler identification is GNU 13.3.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Reading 'vsg_...' macros from /home/robert/dev/VulkanSceneGraph/cmake/vsgMacros.cmake - look there for documentation
-- Found Vulkan: /usr/lib/x86_64-linux-gnu/libvulkan.so (found suitable version "1.3.290", minimum required is "1.1.70.0") found components: glslc glslangValidator
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
CMake Warning at CMakeLists.txt:52 (message):
glslang not found. ShaderCompile support disabled.

-- Found PkgConfig: /usr/bin/pkg-config (found version "1.8.1")
-- Checking for module 'xcb'
-- Found xcb, version 1.15
-- Performing Test HAVE_CXX_ATOMIC_WITHOUT_LIB
-- Performing Test HAVE_CXX_ATOMIC_WITHOUT_LIB - Success
-- The following REQUIRED packages have been found:

  • Vulkan (required version >= 1.1.70.0)
  • Threads
  • PkgConfig

-- Configuring done (0.4s)
-- Generating done (0.0s)
-- Build files have been written to: /home/robert/dev/VulkanSceneGraph

@AnyOldName3
Copy link
Contributor

13 definitely didn't work on Windows, and 12 definitely didn't work on several platforms, but I don't entirely remember the details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants