Skip to content

Conversation

@LinuxJedi
Copy link
Member

This adds bare metal wolfCrypt test with hardware RNG and AES-GCM for STM32H753 using Renode.

Renode does not support HASH HAL at this time.

@LinuxJedi LinuxJedi force-pushed the renode branch 4 times, most recently from 4dcdd7d to 9e405f9 Compare December 19, 2025 17:09
@LinuxJedi LinuxJedi marked this pull request as ready for review December 19, 2025 17:09
@devin-ai-integration
Copy link
Contributor

🛟 Devin Lifeguard found 4 likely issues in this PR

  • no-void-functions snippet snippet: Change helper and handler functions such as static void uart_init(void) (main.c) and void Reset_Handler(void) (startup_stm32h753.c) to return a meaningful status/error code (e.g. int uart_init(void) returning 0 on success) and update their call-sites accordingly, eliminating void return types.
  • no-void-functions snippet: Change helper routines like static void uart_init(void) to return an error/status code (e.g., int uart_init(void) returning 0 on success, negative on failure) and propagate those values to callers; apply the same pattern to other void functions introduced in this commit.
  • check-all-return-codes snippet: Capture the return value of each setvbuf call (e.g., int rc = setvbuf(stdin, NULL, _IONBF, 0);) and, if it is non-zero, report the error via uart_puts or halt the test to avoid undefined buffering behaviour.
  • use-typedefs-not-stdint snippet snippet: Replace the newly introduced uint32_t (and other <stdint.h> types) with the project’s typedefs (e.g., change volatile uint32_t * to volatile word32 * in main.c and startup_stm32h753.c).

@LinuxJedi
please take a look at the above issues which Devin flagged. Devin will not fix these issues automatically.

This adds bare metal wolfCrypt test with hardware RNG and AES-GCM for
STM32H753 using Renode.

Renode does not support HASH HAL at this time.
@LinuxJedi
Copy link
Member Author

Jenkins retest this please: SSH to builder fail

@dgarske
Copy link
Contributor

dgarske commented Dec 23, 2025

Jenkins retest this please. history lost

Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trailing whitespace:
./.github/renode-test/stm32h753/entrypoint.sh:114:····
./.github/renode-test/stm32h753/entrypoint.sh:124:····
./.github/renode-test/stm32h753/entrypoint.sh:132:····
./.github/renode-test/stm32h753/entrypoint.sh:138:····
./.github/renode-test/stm32h753/entrypoint.sh:143:····
./.github/renode-test/stm32h753/entrypoint.sh:153:····
./.github/renode-test/stm32h753/main.c:33:····
./.github/workflows/renode-stm32h753.yml:133:········
./.github/workflows/renode-stm32h753.yml:135:········
./.github/workflows/renode-stm32h753.yml:141:········
[...and more...]
flush-left function calls:
./.github/renode-test/stm32h753/startup_stm32h753.c:71:__attribute__((weak, alias("Default_Handler"))) void NMI_Handler(void);
./.github/renode-test/stm32h753/startup_stm32h753.c:72:__attribute__((weak, alias("Default_Handler"))) void HardFault_Handler(void);
./.github/renode-test/stm32h753/startup_stm32h753.c:73:__attribute__((weak, alias("Default_Handler"))) void MemManage_Handler(void);
./.github/renode-test/stm32h753/startup_stm32h753.c:74:__attribute__((weak, alias("Default_Handler"))) void BusFault_Handler(void);
./.github/renode-test/stm32h753/startup_stm32h753.c:75:__attribute__((weak, alias("Default_Handler"))) void UsageFault_Handler(void);
./.github/renode-test/stm32h753/startup_stm32h753.c:76:__attribute__((weak, alias("Default_Handler"))) void SVC_Handler(void);
./.github/renode-test/stm32h753/startup_stm32h753.c:77:__attribute__((weak, alias("Default_Handler"))) void DebugMon_Handler(void);
./.github/renode-test/stm32h753/startup_stm32h753.c:78:__attribute__((weak, alias("Default_Handler"))) void PendSV_Handler(void);
./.github/renode-test/stm32h753/startup_stm32h753.c:79:__attribute__((weak, alias("Default_Handler"))) void SysTick_Handler(void);
unneeded entries in .wolfssl_known_macro_extras:
WOLFSSL_STM32_RNG_NOLIB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants